From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MHm1C-0004VG-Or for mharc-grub-devel@gnu.org; Fri, 19 Jun 2009 17:53:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHm1B-0004V1-Dd for grub-devel@gnu.org; Fri, 19 Jun 2009 17:53:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHm16-0004Up-D2 for grub-devel@gnu.org; Fri, 19 Jun 2009 17:53:04 -0400 Received: from [199.232.76.173] (port=34905 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHm16-0004Um-96 for grub-devel@gnu.org; Fri, 19 Jun 2009 17:53:00 -0400 Received: from c60.cesmail.net ([216.154.195.49]:61472) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MHm15-0000o3-Oi for grub-devel@gnu.org; Fri, 19 Jun 2009 17:53:00 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 19 Jun 2009 17:52:58 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 302E434C6A for ; Fri, 19 Jun 2009 17:58:42 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <1245429440.28417.29.camel@mj> Content-Type: text/plain Date: Fri, 19 Jun 2009 17:52:56 -0400 Message-Id: <1245448376.672.23.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Proposal for GNU indent compatibility X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2009 21:53:05 -0000 On Fri, 2009-06-19 at 19:01 +0200, Vladimir 'phcoder' Serbinenko wrote: > 8) Removed spaces before labels Oh, I missed that. I think we should follow GNU indent in the label placement as well. > it has put { on new line and without spacing > Perhaps something more. The patch would be 77280 lines. If someone > there would be a way to check indent doen't introduce bugs we could > run it sometimes on all .c files. I'm sure it doesn't introduce bugs, but it can mangle some code. My point is that we should accept the code processed by GNU indent without any additional changes unless GNU indent obviously mangles the code. There should be no coding conventions that GNU indent doesn't follow. I don't think we need to reindent everything. -- Regards, Pavel Roskin