From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MIXcT-00008G-7r for mharc-grub-devel@gnu.org; Sun, 21 Jun 2009 20:42:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIXcR-000066-0X for grub-devel@gnu.org; Sun, 21 Jun 2009 20:42:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIXcM-00005e-0f for grub-devel@gnu.org; Sun, 21 Jun 2009 20:42:42 -0400 Received: from [199.232.76.173] (port=54771 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIXcL-00005b-SP for grub-devel@gnu.org; Sun, 21 Jun 2009 20:42:37 -0400 Received: from c60.cesmail.net ([216.154.195.49]:51206) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MIXcK-0006xS-Im for grub-devel@gnu.org; Sun, 21 Jun 2009 20:42:36 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 21 Jun 2009 20:42:34 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 2966334C6A for ; Sun, 21 Jun 2009 20:48:37 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Sun, 21 Jun 2009 20:42:33 -0400 Message-Id: <1245631353.9864.7.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] File access library for lua X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2009 00:42:43 -0000 On Sun, 2009-06-21 at 19:33 +0800, Bean wrote: > I've added a few function in the lua grub library to access files: ... > I also enable the string library from lua. The patch doesn't introduce any compiler warnings, and that's good. It makes lua.mod bigger by about 10%, but it's very little compared to the added functionality. Please don't add trailing whitespace. STGit detects it in two places. There are several cases of missing spaces before parentheses. We probably need NESTED_FUNC_ATTR in the dir definition in struct grub_fs, as it takes two arguments. But is a separate issue. I'm feeling uneasy about having a parser in GRUB that is not used by default, but it's not related to the quality of the patch. -- Regards, Pavel Roskin