From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MIZ8r-0006iY-6w for mharc-grub-devel@gnu.org; Sun, 21 Jun 2009 22:20:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIZ8o-0006gK-L4 for grub-devel@gnu.org; Sun, 21 Jun 2009 22:20:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIZ8j-0006Xi-KZ for grub-devel@gnu.org; Sun, 21 Jun 2009 22:20:13 -0400 Received: from [199.232.76.173] (port=34638 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIZ8j-0006XL-Gh for grub-devel@gnu.org; Sun, 21 Jun 2009 22:20:09 -0400 Received: from c60.cesmail.net ([216.154.195.49]:1492) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MIZ8j-0004dK-0J for grub-devel@gnu.org; Sun, 21 Jun 2009 22:20:09 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 21 Jun 2009 22:20:05 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 7DC5D34C6A for ; Sun, 21 Jun 2009 22:26:08 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090621191934.GA21827@thorin> References: <20090621181748.GA21152@thorin> <20090621191934.GA21827@thorin> Content-Type: text/plain Date: Sun, 21 Jun 2009 22:20:04 -0400 Message-Id: <1245637204.9864.78.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] rename kernel.elf to kernel.img (Re: [PATCH] i386-qemu port) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2009 02:20:15 -0000 On Sun, 2009-06-21 at 21:19 +0200, Robert Millan wrote: > If you check my earlier patch, you'll see i386-qemu.rmk is just a stub > that includes i386-coreboot.rmk. This is to reduce code duplication > (untill we have a more flexible build system). > > This patch renames kernel.elf to kernel.img in ELF platforms, so that > more variables / etc can be shared with non-ELF ones. No objections as long as it compiles without warnings. Sharing more code is a good thing. By please note that I had to add kernel_elf_ASFLAGS in i386-ieee1275.rmk, or with would not compile on x86_64, as some compiler invocations would miss -m32. So you patch will need to be adjusted for that. -- Regards, Pavel Roskin