From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MImCM-0003yN-J7 for mharc-grub-devel@gnu.org; Mon, 22 Jun 2009 12:16:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MImCL-0003yI-7h for grub-devel@gnu.org; Mon, 22 Jun 2009 12:16:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MImCG-0003xd-FE for grub-devel@gnu.org; Mon, 22 Jun 2009 12:16:44 -0400 Received: from [199.232.76.173] (port=49972 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MImCG-0003xS-9P for grub-devel@gnu.org; Mon, 22 Jun 2009 12:16:40 -0400 Received: from mx20.gnu.org ([199.232.41.8]:13345) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MImCE-0004UZ-LD for grub-devel@gnu.org; Mon, 22 Jun 2009 12:16:39 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MImCD-0003SA-QD for grub-devel@gnu.org; Mon, 22 Jun 2009 12:16:38 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 22 Jun 2009 12:16:36 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id E99BC34C6A for ; Mon, 22 Jun 2009 12:22:44 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090622101056.GD8969@thorin> References: <20090621181748.GA21152@thorin> <20090621185444.GA21590@thorin> <1245611156.4250.11.camel@mj> <20090621192555.GB21827@thorin> <1245636853.9864.74.camel@mj> <20090622101056.GD8969@thorin> Content-Type: text/plain Date: Mon, 22 Jun 2009 12:16:35 -0400 Message-Id: <1245687395.26471.21.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-Detected-Operating-System: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] move grub_stop() (Re: [PATCH] i386-qemu port) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2009 16:16:45 -0000 On Mon, 2009-06-22 at 12:10 +0200, Robert Millan wrote: > My aim was to move this to C code so it can be shared between i386-qemu > and i386-coreboot. However, this code will be the same on other i386 > ports, but we don't yet have a generic .S file for i386 code. > > How about kern/i386/misc.S ? Fine with me. We shouldn't switch to inferior C code just because we don't have a shared .S file. > This seems to be the current behaviour, unless I missed something. OK, never mind. I should have done that analysis before bringing up the issue. Anyway, I think grub_halt() should be renamed to grub_poweroff() to be more explicit about its goal. -- Regards, Pavel Roskin