From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MIupc-0005Ki-8p for mharc-grub-devel@gnu.org; Mon, 22 Jun 2009 21:29:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIupa-0005KP-0C for grub-devel@gnu.org; Mon, 22 Jun 2009 21:29:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIupV-0005Jk-KZ for grub-devel@gnu.org; Mon, 22 Jun 2009 21:29:49 -0400 Received: from [199.232.76.173] (port=53979 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIupV-0005JQ-8G for grub-devel@gnu.org; Mon, 22 Jun 2009 21:29:45 -0400 Received: from c60.cesmail.net ([216.154.195.49]:55706) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MIupU-00019z-Pg for grub-devel@gnu.org; Mon, 22 Jun 2009 21:29:45 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 22 Jun 2009 21:29:42 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 16FE934C6A for ; Mon, 22 Jun 2009 21:35:54 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090622230751.GD11998@thorin> References: <20090621181748.GA21152@thorin> <20090622230751.GD11998@thorin> Content-Type: text/plain Date: Mon, 22 Jun 2009 21:29:41 -0400 Message-Id: <1245720581.30815.11.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2009 01:29:50 -0000 On Tue, 2009-06-23 at 01:07 +0200, Robert Millan wrote: > This is my first "clean" (kludge-free) patch for the i386-qemu port. It > doesn't depend on any other patch; I send it for some final review before > checking it in. In some cases, "2" appears on the command line. Perhaps the initial keyboard state is not cleared. If I use all modules, the image is too big: grub-mkimage: error: Core image is too big (0xa8200 > 0xa0000) If I exclude lua.mod, I can build the image, but it fails in qemu with the message "no module name found". Removing udf.mod helps. Likewise, removing several other modules helps. I believe memory is corrupted if there are too many modules. Also, if "no module name found" appears, it's followed by: Aborted. Press any key to exit.grub_exit() is not implemented. And it appears on the new line every time a key is pressed. I believe grub_exit() should call grub_halt() for i386-coreboot and i386-qemu. -- Regards, Pavel Roskin