From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MIvAo-0005Fo-AK for mharc-grub-devel@gnu.org; Mon, 22 Jun 2009 21:51:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIvAm-0005Ff-AH for grub-devel@gnu.org; Mon, 22 Jun 2009 21:51:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIvAh-0005F6-4m for grub-devel@gnu.org; Mon, 22 Jun 2009 21:51:43 -0400 Received: from [199.232.76.173] (port=53984 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIvAh-0005F3-17 for grub-devel@gnu.org; Mon, 22 Jun 2009 21:51:39 -0400 Received: from c60.cesmail.net ([216.154.195.49]:13368) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MIvAg-0004Y5-Gd for grub-devel@gnu.org; Mon, 22 Jun 2009 21:51:38 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 22 Jun 2009 21:51:37 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id A251C34C6A for ; Mon, 22 Jun 2009 21:57:48 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090622234859.GA16795@thorin> References: <20090622234859.GA16795@thorin> Content-Type: text/plain Date: Mon, 22 Jun 2009 21:51:35 -0400 Message-Id: <1245721895.809.18.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] search -d|--disk X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2009 01:51:44 -0000 On Tue, 2009-06-23 at 01:48 +0200, Robert Millan wrote: > This patch adds an option to the search command to restrict the search of > a file to a given disk. It will then probe for the file in each of its > partitions, but not in other disks. First of all, it would be great is all proposals to add more code come with a possible use case. We are approaching the point when grub with all modules would become too big to some boot partitions. "VAR" should be "DISK". "in this disk" should be "on this disk" (disclaimer: English is not my native language). "and its partitions" seems excessive to me. If the disk has partitions, of course that where we would look. The implementation is not working: sh:grub> search -d foo -l / hd0,3 I hope that it would be possible to specify a partition for the disk, so that we easily can look e.g. for a partition with label "/" on a disk with a partition containing "/boot/grub/grub.cfg". -- Regards, Pavel Roskin