From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: regression introduced on v2.6.30-rc1
Date: Tue, 23 Jun 2009 16:40:36 +0200 [thread overview]
Message-ID: <1245768036.15367.78.camel@violet> (raw)
In-Reply-To: <2d5a2c100906230651m679ccfat5bf4bfb20c130955@mail.gmail.com>
Hi Luiz,
> Cleanup version, which include code style fixing suggested by Johan on irc.
>
> There are 2 other things that comes to my mind that need discussing:
>
> - 20 sec timeout is perhaps too big
> - clear the timer on rfcomm_session_close is perhaps not save then we
> can move it to rfcomm_session_del
what about just triggering the timer and then sending DISC for DLCI 0. I
don't see a big benefit for this reference counting overhead.
When we send the DISC, we will receive UA and thus get the required
rfcomm_session_put() that then leads to the ACL disconnect.
Regards
Marcel
next prev parent reply other threads:[~2009-06-23 14:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 13:17 regression introduced on v2.6.30-rc1 Luiz Augusto von Dentz
2009-06-21 14:08 ` Luiz Augusto von Dentz
2009-06-21 14:48 ` Marcel Holtmann
2009-06-21 16:30 ` Luiz Augusto von Dentz
2009-06-21 16:58 ` Marcel Holtmann
2009-06-21 17:47 ` Luiz Augusto von Dentz
2009-06-21 19:04 ` Marcel Holtmann
2009-06-22 21:49 ` Luiz Augusto von Dentz
2009-06-22 23:08 ` Luiz Augusto von Dentz
2009-06-23 13:51 ` Luiz Augusto von Dentz
2009-06-23 14:40 ` Marcel Holtmann [this message]
2009-06-23 15:01 ` Luiz Augusto von Dentz
2009-06-23 15:06 ` Marcel Holtmann
2009-06-23 18:04 ` Stefan Seyfried
2009-06-23 18:13 ` Luiz Augusto von Dentz
2009-06-23 18:56 ` Luiz Augusto von Dentz
2009-06-25 13:14 ` Luiz Augusto von Dentz
2009-06-30 20:18 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245768036.15367.78.camel@violet \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.