From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MJECW-0008RZ-Gq for mharc-grub-devel@gnu.org; Tue, 23 Jun 2009 18:10:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJECU-0008Qr-L3 for grub-devel@gnu.org; Tue, 23 Jun 2009 18:10:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJECP-0008OD-0T for grub-devel@gnu.org; Tue, 23 Jun 2009 18:10:45 -0400 Received: from [199.232.76.173] (port=45075 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJECO-0008O7-Q4 for grub-devel@gnu.org; Tue, 23 Jun 2009 18:10:40 -0400 Received: from c60.cesmail.net ([216.154.195.49]:51717) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MJECO-00069V-9a for grub-devel@gnu.org; Tue, 23 Jun 2009 18:10:40 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 23 Jun 2009 18:10:38 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 70C1234C88 for ; Tue, 23 Jun 2009 18:16:57 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20090622105959.GI8969@thorin> <1245695500.1926.10.camel@mj> <1245697145.1926.11.camel@mj> <1245698882.24040.1.camel@mj> <1245701210.2754.12.camel@mj> Content-Type: text/plain Date: Tue, 23 Jun 2009 18:10:36 -0400 Message-Id: <1245795036.3204.26.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] File access library for lua X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2009 22:10:47 -0000 On Tue, 2009-06-23 at 17:27 +0800, Bean wrote: > Hi, > > Some bug fix for osdetect.lua, it also detect windows 98/me, freedos, > msdos and freebsd. Why FressDOS and FressBSD? I assume it's typos. Why isn't Linux capitalized? MS-DOS is written with a dash. "Windows Vista bootmgr" should be "Windows Vista" and "Windows NT/2000/XP loader" should be "Windows NT/2000/XP". It's not like we are just booting the loaders. inird should be initrd. Please add check for the Fedora style names for initrd, namely "initrd-KVER.img". Or maybe you just missed ".img" in the second check? > Extend the function of grub.file_exist to allow testing multiple names > at the same time, this simplify osdetect.lua. The change to grub_lua_file_exist() is dubious. It's not clear why the requirement is that all files exist. Maybe I don't know the style of lua, but I think it's wrong to hardcode the AND logic just because one script would benefit from it. If we consider e.g. the wildcard expansion in make, it will return a non-empty value if any file exists, i.e. the OR logic is used. I suggest that you split the lua.mod changes and osdetect.lua. The later is obviously a bikeshed issue that can be discussed for a long time. The former needs a more technical consideration. -- Regards, Pavel Roskin