All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] perf_counter tools: shorten names for events
Date: Wed, 24 Jun 2009 03:42:53 +0530	[thread overview]
Message-ID: <1245795173.26280.17.camel@localhost.localdomain> (raw)
In-Reply-To: <20090623195656.GC8777@elte.hu>

On Tue, 2009-06-23 at 21:56 +0200, Ingo Molnar wrote:
> * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> 
> > After :
> > 
> >  Performance counter stats for 'ls -lR /usr/include/':
> > 
> >       259250339  L1-d-load-refs        (scaled from 22.73%)
> >         1187200  L1-d-load-miss        (scaled from 23.01%)
> >          150454  L1-d-store-refs       (scaled from 23.01%)
> >          494252  L1-d-prefetch-refs    (scaled from 23.29%)
> >          362661  L1-d-prefetch-miss    (scaled from 23.73%)
> >       247343449  L1-i-load-refs        (scaled from 23.71%)
> >         4804990  L1-i-load-miss        (scaled from 23.85%)
> >          108711  L1-i-prefetch-refs    (scaled from 23.83%)
> >         6260313  L2-load-refs          (scaled from 23.82%)
> >          605425  L2-load-miss          (scaled from 23.82%)
> >         6898075  L2-store-refs         (scaled from 23.96%)
> >       248334160  d-TLB-load-refs       (scaled from 23.95%)
> >         3812835  d-TLB-load-miss       (scaled from 23.87%)
> >       253208496  i-TLB-load-refs       (scaled from 23.73%)
> >            5873  i-TLB-load-miss       (scaled from 23.46%)
> >       110891027  Branch-load-refs      (scaled from 23.21%)
> >         5529622  Branch-load-miss      (scaled from 23.02%)
> 
> here's an edited version of my suggestions:
> 
> >       259250339  dL1-loads              (scaled from 22.73%)
> >         1187200  dL1-load-misses        (scaled from 23.01%)
> >          150454  dL1-stores             (scaled from 23.01%)
> >          494252  dL1-prefetches         (scaled from 23.29%)
> >          362661  dL1-prefetch-misses    (scaled from 23.73%)
> >       247343449  iL1-loads              (scaled from 23.71%)
> >         4804990  iL1-load-misses        (scaled from 23.85%)
> >          108711  iL1-prefetches         (scaled from 23.83%)
> >         6260313  LLC-loads              (scaled from 23.82%)
> >          605425  LLC-load-misses        (scaled from 23.82%)
> >         6898075  LLC-stores             (scaled from 23.96%)
> >       248334160  dTLB-loads             (scaled from 23.95%)
> >         3812835  dTLB-load-misses       (scaled from 23.87%)
> >       253208496  iTLB-loads             (scaled from 23.73%)
> >            5873  iTLB-load-misses       (scaled from 23.46%)
> >       110891027  branches               (scaled from 23.21%)
> >         5529622  branch-misses          (scaled from 23.02%)
> 
> We can leave out 'refs' i think - without any qualification 
> statements like '247343449 iL1-loads' are still unambigious i think.
> 

Looks good.

> Plus we can abbreviate dL1/iL1/dTLB/iTLB. The capitalization 
> matters. Also, note that it's LLC (Last Level Cache), not L2.
> 
> ( Sidenote: L2 can still be an alias for LLC, even though some CPUs 
>   have a L3 too. )
> 

Ok, I will fix it and also set the alias.

> Note, branches are special - we dont really have 'branch loads', 
> branches are executions. 'Branches' and 'Branch-misses' are the 
> right term.
> 
> Do you agree?
> 

Event we used for (BPU, READ, ACCESS) is 'branch instructions retired'

So 'branch loads' we mean 'branch instruction loaded and retired'

I like all of them : 'branch loads', 'branch retired' or 'branches'

Please let me know, which one is best option so that I can prepare the
patch.

Thanks,
--
JSR 




  reply	other threads:[~2009-06-23 22:13 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-23 12:28 [PATCH -tip] perf_counter tools: shorten names for events Jaswinder Singh Rajput
2009-06-23 13:52 ` Jaswinder Singh Rajput
2009-06-23 19:56 ` Ingo Molnar
2009-06-23 22:12   ` Jaswinder Singh Rajput [this message]
2009-06-23 22:59     ` Jaswinder Singh Rajput
2009-06-24  8:40     ` Ingo Molnar
2009-06-24 17:59       ` Jaswinder Singh Rajput
2009-06-24 18:07         ` Ingo Molnar
2009-06-24 18:18           ` Jaswinder Singh Rajput
2009-06-24 20:41   ` Jaswinder Singh Rajput
2009-06-24 21:00     ` Thomas Gleixner
2009-06-25  4:29       ` Jaswinder Singh Rajput
2009-06-25  4:34         ` Roland Dreier
2009-06-25  9:22           ` Ingo Molnar
2009-06-25  9:24       ` Ingo Molnar
2009-06-25 12:48         ` Thomas Gleixner
2009-06-25 13:23           ` Jaswinder Singh Rajput
2009-06-25 15:05             ` Roland Dreier
2009-06-25 15:11               ` Jaswinder Singh Rajput
2009-06-25 15:03         ` Roland Dreier
2009-06-25 15:24           ` Ingo Molnar
2009-06-25  9:33     ` Ingo Molnar
2009-06-25 12:55       ` Jaswinder Singh Rajput
2009-06-25 15:09         ` Roland Dreier
2009-06-25 15:26           ` Ingo Molnar
2009-06-25 15:34           ` Ingo Molnar
2009-06-26 16:06             ` Jaswinder Singh Rajput
2009-06-26 18:47               ` Ingo Molnar
2009-07-05  0:25           ` Anton Blanchard
2009-07-05  0:32             ` Ingo Molnar
2009-07-06 12:01               ` [PATCH] perf_counter tools: Rename cache events to remove $ Anton Blanchard
2009-07-10 10:39                 ` [tip:perfcounters/core] " tip-bot for Anton Blanchard
2009-06-25 15:33         ` [tip:perfcounters/urgent] perf_counter tools: Shorten names for events tip-bot for Jaswinder Singh Rajput
2009-06-25 15:57           ` Jaswinder Singh Rajput
2009-06-25 19:55             ` Ingo Molnar
2009-06-25 19:57             ` [tip:perfcounters/urgent] perf_counter tools: Add alias for 'l1d' and 'l1i' tip-bot for Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245795173.26280.17.camel@localhost.localdomain \
    --to=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.