From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MJvuo-0006CJ-Mu for mharc-grub-devel@gnu.org; Thu, 25 Jun 2009 16:51:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJvul-00068o-HZ for grub-devel@gnu.org; Thu, 25 Jun 2009 16:51:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJvuf-000633-6w for grub-devel@gnu.org; Thu, 25 Jun 2009 16:51:21 -0400 Received: from [199.232.76.173] (port=38787 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJvue-00062W-Po for grub-devel@gnu.org; Thu, 25 Jun 2009 16:51:16 -0400 Received: from c60.cesmail.net ([216.154.195.49]:54438) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MJvud-0000CP-Ty for grub-devel@gnu.org; Thu, 25 Jun 2009 16:51:16 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 25 Jun 2009 16:51:13 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id A950F34C6A for ; Thu, 25 Jun 2009 16:57:49 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090625203108.GB4344@thorin> References: <20090621181748.GA21152@thorin> <20090622230751.GD11998@thorin> <1245720581.30815.11.camel@mj> <20090623113850.GB24028@thorin> <20090623121325.GA3130@thorin> <20090624010032.GA19305@thorin> <20090624231005.GA30986@thorin> <1245959608.18261.64.camel@mj> <20090625203108.GB4344@thorin> Content-Type: text/plain Date: Thu, 25 Jun 2009 16:51:11 -0400 Message-Id: <1245963071.3196.6.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2009 20:51:25 -0000 On Thu, 2009-06-25 at 22:31 +0200, Robert Millan wrote: > You mean for efiemu? Seems fine. But I wouldn't use "target/host" > naming, since it doesn't match with existing usage of those names > elsewhere, which makes it very confusing. > > How about "native/cross"? Fine with me. Whatever is meaningful. > I agree there's no point in making all architectures do this. However, > note that we'll probably see more architectures with read-only modules > in the future (other qemu ports, but also any port where GRUB runs > standalone). > > I was thinking that we could just #ifdef the symtab allocation (and the > symtab field declaration as well). Since it's just a few lines, I think > it'll look readable. I'd like to avoid preprocessor conditionals in kern/ARCH/dl.c files if possible. There is no harm in keeping mod->symtab and using it instead of the local "symtab" variables. -- Regards, Pavel Roskin