From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MKF2y-0001MF-6L for mharc-grub-devel@gnu.org; Fri, 26 Jun 2009 13:17:08 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MKF2w-0001Lc-IC for grub-devel@gnu.org; Fri, 26 Jun 2009 13:17:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MKF2r-0001In-PD for grub-devel@gnu.org; Fri, 26 Jun 2009 13:17:06 -0400 Received: from [199.232.76.173] (port=58002 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MKF2r-0001Ib-Ki for grub-devel@gnu.org; Fri, 26 Jun 2009 13:17:01 -0400 Received: from c60.cesmail.net ([216.154.195.49]:26396) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MKF2r-00005X-31 for grub-devel@gnu.org; Fri, 26 Jun 2009 13:17:01 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 26 Jun 2009 13:16:59 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 6D05C34C6D for ; Fri, 26 Jun 2009 13:23:42 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090626170339.GA22854@thorin> References: <1245720581.30815.11.camel@mj> <20090623113850.GB24028@thorin> <20090623121325.GA3130@thorin> <20090624010032.GA19305@thorin> <20090624231005.GA30986@thorin> <1245959608.18261.64.camel@mj> <20090625203108.GB4344@thorin> <1245963071.3196.6.camel@mj> <20090626144107.GA21789@thorin> <1246034647.1036.39.camel@mj> <20090626170339.GA22854@thorin> Content-Type: text/plain Date: Fri, 26 Jun 2009 13:16:57 -0400 Message-Id: <1246036617.6207.6.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2009 17:17:06 -0000 On Fri, 2009-06-26 at 19:03 +0200, Robert Millan wrote: > 03-simple-symtab.patch looks nice, much cleaner than what I had. Thanks! > But as for 02-elf-renames.patch we could try to make this more consistent. In > efiemu I used 'W' (inspired by ElfW() macro in glibc), then in some places you > use 'K' and in other places 'T'. Can we use the same everywhere? I don't > care which letter, I'm not THAT much into bikeshed :-) "T" stands for "target" and "K" stands for "kernel". Yes, we can use ElfW everywhere. But I would try to avoid any mass renames. It's very easy to write Elf instead of ElfW somewhere in the code, and it would compile, but it won't work. Maybe we could have two headers, elf32.h and elf64.h, and every file that needs Elf definitions would include one of them, dependent on which elf format it wants. Including both elf32.h and elf64.h from one source should be impossible. It could be a separate patch that would go in before the ROM modules support. -- Regards, Pavel Roskin