Re: [PATCH] PCAP touchscreen driver (for 2.6.32)

[Daniel Ribeiro <drwyrm@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

Em Dom, 2009-06-28 às 12:45 +0530, Trilok Soni escreveu:
> 2009/6/27 Daniel Ribeiro <drwyrm@gmail.com>:
> > Touchscreen driver for PCAP2 PMIC.

> Some more description in commit text really helps.

Well, there isn't much to say. :) Its a touchscreen driver for a
proprietary PMIC on Motorola phones.

> > +       err = request_irq(pcap_to_irq(pcap_ts->pcap, PCAP_IRQ_TS),
> > +                       pcap_ts_event_touch, 0, "Touch Screen", pcap_ts);
> > +       if (err)
> > +               goto fail;
> > +
> > +       err = input_register_device(pcap_ts->input);
> > +       if (err)
> > +               goto fail_touch;
> 
> Please move request_irq after input_register_device, as IRQ can get
> fired before input device gets available, right?

Yes, you are right, I will move it.

> Overall driver is nice and clean.

Thanks for the review! :)

-- 
Daniel Ribeiro

[-- Attachment #2: Esta é uma parte de mensagem assinada digitalmente --]
[-- Type: application/pgp-signature, Size: 197 bytes --]