From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ML8BN-00006c-HE for mharc-grub-devel@gnu.org; Mon, 29 Jun 2009 00:09:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ML8BK-00006A-UV for grub-devel@gnu.org; Mon, 29 Jun 2009 00:09:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ML8BF-00005y-Js for grub-devel@gnu.org; Mon, 29 Jun 2009 00:09:25 -0400 Received: from [199.232.76.173] (port=53201 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ML8BF-00005v-FE for grub-devel@gnu.org; Mon, 29 Jun 2009 00:09:21 -0400 Received: from c60.cesmail.net ([216.154.195.49]:54832) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1ML8BE-0000wc-Oi for grub-devel@gnu.org; Mon, 29 Jun 2009 00:09:21 -0400 Received: from unknown (HELO smtprelay1.cesmail.net) ([192.168.1.111]) by c60.cesmail.net with ESMTP; 29 Jun 2009 00:09:19 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay1.cesmail.net (Postfix) with ESMTPSA id 52A6934C6D for ; Mon, 29 Jun 2009 00:09:18 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090627121216.GA29067@thorin> References: <20090627121216.GA29067@thorin> Content-Type: text/plain Date: Mon, 29 Jun 2009 00:09:16 -0400 Message-Id: <1246248556.22661.24.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] export -boot parameter as qemu_boot{0,1,2} X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2009 04:09:27 -0000 On Sat, 2009-06-27 at 14:12 +0200, Robert Millan wrote: > This patch makes GRUB gather the -boot parameter from CMOS and > export it as a set of variables (qemu_boot{0,1,2}), which can > be observed in grub.cfg scripts. I think qemu constants belong to a separate header. Use of a nested function seems totally unwarranted. We actually agreed a while ago that they are bad, but nobody had time to remove them. Please use ARRAY_SIZE to calculate the number of elements. -- Regards, Pavel Roskin