From: Daniel Ribeiro <drwyrm@gmail.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: sameo@linux.intel.com, LKML <linux-kernel@vger.kernel.org>,
laforge@openezx.org
Subject: Re: MFD: mutex from ISR in ezx-pcap?
Date: Tue, 30 Jun 2009 05:57:36 -0300 [thread overview]
Message-ID: <1246352256.18231.408.camel@brutus> (raw)
In-Reply-To: <4A493BF9.7010304@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
Em Ter, 2009-06-30 às 00:11 +0200, Jiri Slaby escreveu:
> > pcap_adc_irq actually already runs from a workqueue (pcap_isr_work).
>
> Aha, thanks, there is a specific irq handler. Ok, sounds fair.
>
> But interrupts are disabled in pcap_isr_work anyway,
Right.
> so that
> pcap_adc_irq shouldn't sleep, right? Or maybe I missed something again...
No. Interrupts are enabled again before pcap_adc_irq() runs.
pcap_isr_work() doesn't call pcap_adc_irq directly, it calls the
irq_flow_handler, handle_simple_irq(), which needs to run with
interrupts disabled. Interrupts are enabled again on handle_IRQ_event(),
as pcap_adc_irq is requested _without_ IRQF_DISABLED.
--
Daniel Ribeiro
[-- Attachment #2: Esta é uma parte de mensagem assinada digitalmente --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-06-30 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 19:34 MFD: mutex from ISR in ezx-pcap? Jiri Slaby
2009-06-29 20:20 ` Daniel Ribeiro
2009-06-29 22:11 ` Jiri Slaby
2009-06-30 8:57 ` Daniel Ribeiro [this message]
2009-07-01 6:56 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246352256.18231.408.camel@brutus \
--to=drwyrm@gmail.com \
--cc=jirislaby@gmail.com \
--cc=laforge@openezx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.