From: Andy Isaacson <adi@vmware.com>
To: linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net
Cc: adi@hexapodia.org, Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
dds@google.com, Mimi Zohar <zohar@linux.vnet.ibm.com>,
Shahbaz Khan <shaz.linux@gmail.com>,
seiji.munetoh@gmail.com, Andy Isaacson <adi@vmware.com>
Subject: [PATCH 1/6] tpm_tis: various cleanups
Date: Tue, 30 Jun 2009 18:04:10 -0700 [thread overview]
Message-ID: <1246410255-6839-2-git-send-email-adi@vmware.com> (raw)
In-Reply-To: <1246410255-6839-1-git-send-email-adi@vmware.com>
Avoid tabs in printk output.
Use parentheses and ARRAY_SIZE() in macro definition.
Signed-off-by: Andy Isaacson <adi@vmware.com>
---
drivers/char/tpm/tpm_tis.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 717af7a..1b84441 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -474,23 +474,23 @@ static int tpm_tis_init(struct device *dev, resource_size_t start,
dev_dbg(dev, "TPM interface capabilities (0x%x):\n",
intfcaps);
if (intfcaps & TPM_INTF_BURST_COUNT_STATIC)
- dev_dbg(dev, "\tBurst Count Static\n");
+ dev_dbg(dev, " Burst Count Static\n");
if (intfcaps & TPM_INTF_CMD_READY_INT)
- dev_dbg(dev, "\tCommand Ready Int Support\n");
+ dev_dbg(dev, " Command Ready Int Support\n");
if (intfcaps & TPM_INTF_INT_EDGE_FALLING)
- dev_dbg(dev, "\tInterrupt Edge Falling\n");
+ dev_dbg(dev, " Interrupt Edge Falling\n");
if (intfcaps & TPM_INTF_INT_EDGE_RISING)
- dev_dbg(dev, "\tInterrupt Edge Rising\n");
+ dev_dbg(dev, " Interrupt Edge Rising\n");
if (intfcaps & TPM_INTF_INT_LEVEL_LOW)
- dev_dbg(dev, "\tInterrupt Level Low\n");
+ dev_dbg(dev, " Interrupt Level Low\n");
if (intfcaps & TPM_INTF_INT_LEVEL_HIGH)
- dev_dbg(dev, "\tInterrupt Level High\n");
+ dev_dbg(dev, " Interrupt Level High\n");
if (intfcaps & TPM_INTF_LOCALITY_CHANGE_INT)
- dev_dbg(dev, "\tLocality Change Int Support\n");
+ dev_dbg(dev, " Locality Change Int Support\n");
if (intfcaps & TPM_INTF_STS_VALID_INT)
- dev_dbg(dev, "\tSts Valid Int Support\n");
+ dev_dbg(dev, " Sts Valid Int Support\n");
if (intfcaps & TPM_INTF_DATA_AVAIL_INT)
- dev_dbg(dev, "\tData Avail Int Support\n");
+ dev_dbg(dev, " Data Avail Int Support\n");
/* INTERRUPT Setup */
init_waitqueue_head(&chip->vendor.read_queue);
@@ -649,7 +649,7 @@ static struct pnp_driver tis_pnp_driver = {
.remove = tpm_tis_pnp_remove,
};
-#define TIS_HID_USR_IDX sizeof(tpm_pnp_tbl)/sizeof(struct pnp_device_id) -2
+#define TIS_HID_USR_IDX (ARRAY_SIZE(tpm_pnp_tbl) - 2)
module_param_string(hid, tpm_pnp_tbl[TIS_HID_USR_IDX].id,
sizeof(tpm_pnp_tbl[TIS_HID_USR_IDX].id), 0444);
MODULE_PARM_DESC(hid, "Set additional specific HID for this driver to probe");
--
1.6.3.1
next prev parent reply other threads:[~2009-07-01 1:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 1:04 [PATCH 0/6] tpm_tis: various cleanups, and support for Intel iTPM Andy Isaacson
2009-07-01 1:04 ` Andy Isaacson [this message]
2009-09-10 19:56 ` [PATCH 1/6] tpm_tis: various cleanups Rajiv Andrade
2009-07-01 1:04 ` [PATCH 2/6] tpm_tis: add MODULE_DEVICE_TABLE to enable autoload Andy Isaacson
2009-09-10 19:56 ` Rajiv Andrade
2009-07-01 1:04 ` [PATCH 3/6] tpm_tis: set timeouts before calling request_locality Andy Isaacson
2009-07-01 1:04 ` [PATCH 4/6] tpm_tis: print complete vendor information Andy Isaacson
2009-09-10 19:57 ` Rajiv Andrade
2009-07-01 1:04 ` [PATCH 5/6] tpm_tis: convert from pnp_driver to acpi_driver Andy Isaacson
2009-07-01 10:01 ` Alan Cox
2009-07-01 13:45 ` Rajiv Andrade
2009-07-16 17:26 ` Rajiv Andrade
2009-07-16 17:43 ` [PATCH] TPM: DATA_EXPECT bit check bypass Rajiv Andrade
2009-07-16 20:08 ` Valdis.Kletnieks
2009-07-16 20:50 ` Rajiv Andrade
2009-07-16 21:20 ` Rajiv Andrade
2009-07-20 23:28 ` Andy Isaacson
2009-07-24 17:12 ` Rajiv Andrade
2009-07-20 18:27 ` [PATCH 5/6] tpm_tis: convert from pnp_driver to acpi_driver Andy Isaacson
2009-09-10 19:08 ` Rajiv Andrade
2009-09-10 19:54 ` [PATCH] tpm_tis: TPM_STS_DATA_EXPECT workaround Rajiv Andrade
2009-09-10 19:58 ` Daniel Walker
2009-09-10 20:06 ` Rajiv Andrade
2009-09-10 20:09 ` Rajiv Andrade
2009-09-11 23:34 ` Seiji Munetoh
2009-09-24 18:43 ` Rajiv Andrade
2009-10-28 2:45 ` David Smith
2009-10-31 14:24 ` Eric Paris
2009-11-01 22:09 ` James Morris
2009-09-10 20:27 ` Andy Isaacson
2009-07-01 1:04 ` [PATCH 6/6] tpm_tis: add workarounds for iTPM Andy Isaacson
2009-07-03 18:18 ` [tpmdd-devel] " Marcin Obara
2009-07-03 19:33 ` Andy Isaacson
2009-07-03 20:10 ` Marcin Obara
2009-07-03 20:20 ` Andy Isaacson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246410255-6839-2-git-send-email-adi@vmware.com \
--to=adi@vmware.com \
--cc=adi@hexapodia.org \
--cc=dds@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seiji.munetoh@gmail.com \
--cc=shaz.linux@gmail.com \
--cc=srajiv@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.