From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MM0sS-0002wJ-SP for mharc-grub-devel@gnu.org; Wed, 01 Jul 2009 10:33:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MM0sQ-0002vM-IU for grub-devel@gnu.org; Wed, 01 Jul 2009 10:33:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MM0sM-0002tN-39 for grub-devel@gnu.org; Wed, 01 Jul 2009 10:33:33 -0400 Received: from [199.232.76.173] (port=44055 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MM0sL-0002tJ-RW for grub-devel@gnu.org; Wed, 01 Jul 2009 10:33:29 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:49907) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MM0sL-0005tp-Ay for grub-devel@gnu.org; Wed, 01 Jul 2009 10:33:29 -0400 Received: from [85.180.11.92] (e180011092.adsl.alicedsl.de [85.180.11.92]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0MKt2u-1MM0sI0ufc-000nD1; Wed, 01 Jul 2009 16:33:26 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <1243885166.3417.11.camel@fz.local> References: <1241620317.3746.8.camel@fz.local> <1243885166.3417.11.camel@fz.local> Content-Type: text/plain Date: Wed, 01 Jul 2009 16:33:25 +0200 Message-Id: <1246458805.3454.1.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1+lT3LSxTkzIBU3/Dm8Yf3zxYnYYdH6sB3Xe6l SjPJy6J40qK4fQ/c2ARH4do+FblViHN0aWZDDZXMxC9N5VexOe Rnew64VY5JHjdDhVOcEwNF0BJ9RyhE0 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub-install --root-directory=/mnt /dev/sda1 fails X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2009 14:33:35 -0000 Am Montag, den 01.06.2009, 21:39 +0200 schrieb Felix Zielcke: > Am Mittwoch, den 06.05.2009, 17:12 +0200 schrieb Vladimir 'phcoder' > Serbinenko: > > Don't we already have a function which transforms host directory into > > grub > > directory? AFAIR we have. > > There's just the shell function in grub-mkconfig_lib.in > Here's now a patch wich implements it in util/hostdisk.c and gets used > for core_path_dev in setup (). > But it doestn't work with symlinks. > readlink () can only be used if the file pointed to is a symlink, not if > a symlink is somewhere in between. > coreutils where the readlink binary is from is GPL 3+ but the function > for it uses hash tables and it seems like it would be too much code to > copy just for this. So what do we do know about this problem? We could just assume that the directory given with grub-setup --directory is already the real absolute path and just use the stat magic to make it relative. Or we use realpath() if avaible to get the real one. And on systems not having it, like mingw we could just assume that it's already relative and just return the path given. Or is there some other way this bug can be fixed? -- Felix Zielcke