All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Nizette <bn@niasdigital.com>
To: pierre@ossman.eu
Cc: s.hauer@pengutronix.de,
	linux-kernel <linux-kernel@vger.kernel.org>,
	kernel <kernel@avr32linux.org>, Ben Nizette <bn@niasdigital.com>
Subject: [PATCH] MMC Core: Drop initialization frequency floor to 50kHz
Date: Thu, 02 Jul 2009 09:49:56 +1000	[thread overview]
Message-ID: <1246492196.2980.17.camel@linux-51e8.site> (raw)

Patch

commit 8dfd0374be84793360db7fff2e635d2cd3bbcb21
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date:   Thu Apr 9 08:32:02 2009 +0200

    MMC core: limit minimum initialization frequency to 400kHz

Was recently merged.  This is too fast for at least one setup
permutation - the one on my desk which through trial and error won't
initialise at anything above ~350kHz (older Sandisk 256MB SD on
atmel-mci).

To avoid a string of "just found card X which requires clock
(current_clock - epsilon)" this patch drops the floor right down to
50kHz.  This is about the slowest rate before which the discovery
process takes a noticeable slowdown.

Signed-off-by: Ben Nizette <bn@niasdigital.com>
---
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index d84c880..6ee1931 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -708,12 +708,13 @@ static void mmc_power_up(struct mmc_host *host)
 	 */
 	mmc_delay(10);
 
-	if (host->f_min > 400000) {
-		pr_warning("%s: Minimum clock frequency too high for "
-				"identification mode\n", mmc_hostname(host));
-		host->ios.clock = host->f_min;
-	} else
-		host->ios.clock = 400000;
+	/*
+	 * Card discovery is typically done at the controller's minimum
+	 * allowable frequency but for some controllers this is minimum
+	 * is unreasonably slow.  In that case we limit slow clock rate
+	 * to 50KHz.
+	 */
+	host->ios.clock = max(host->f_min, 50000);
 
 	host->ios.power_mode = MMC_POWER_ON;
 	mmc_set_ios(host);



             reply	other threads:[~2009-07-01 23:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 23:49 Ben Nizette [this message]
2009-07-02  7:18 ` [PATCH] MMC Core: Drop initialization frequency floor to 50kHz Pierre Ossman
2009-07-02 11:10   ` Ben Nizette
2009-07-02 11:58 ` Haavard Skinnemoen
2009-07-02 12:17   ` Ben Nizette
     [not found]     ` <4B3E570C.2060602@yahoo.es>
     [not found]       ` <63809451-ED1D-487A-AE63-F72B23D136D8@niasdigital.com>
     [not found]         ` <4B3F019F.6010306@yahoo.es>
2010-01-02  9:07           ` [PATCH v2] mmc: lower init clock frequency to 300kHz Ben Nizette
2010-01-02 12:08             ` Pierre Ossman
2010-01-02 22:23               ` [PATCH v3] mmc: Make ID freq configurable Ben Nizette
2010-01-02 23:04                 ` Robert Hancock
2010-01-02 23:38                 ` Pierre Ossman
2010-01-03  8:00                   ` Hein_Tibosch
2010-01-04 21:07                   ` Hein_Tibosch
2010-01-05 12:24                     ` Sascha Hauer
2010-01-04 21:58                   ` Hein_Tibosch
2010-08-27 20:44                     ` Chris Ball
2010-08-28  0:44                       ` Hein_Tibosch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246492196.2980.17.camel@linux-51e8.site \
    --to=bn@niasdigital.com \
    --cc=kernel@avr32linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre@ossman.eu \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.