From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Bug 1647683" <1647683@bugs.launchpad.net>,
"Richard Henderson" <rth@twiddle.net>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"open list:Overall" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] exec.c: simplify the breakpoint invalidation logic
Date: Wed, 7 Dec 2016 06:32:10 -0500 (EST) [thread overview]
Message-ID: <1246561763.1891130.1481110330525.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAFEAcA8tnP5_annrApB2O_ZUXvc7HXM7+K1XOsPUVqrU6hHLeA@mail.gmail.com>
> I think this is the wrong direction. We only need to invalidate
> the TBs for the specific location the breakpoint is at.
> Even if we for the moment want to apply a big hammer of doing
> a full tb flush on breakpoint to fix this issue for this release,
> we shouldn't drop the indirection through breakpoint_invalidate(),
> because then we can't go back to invalidating just the parts we need
> easily later.
I agree with Peter, but still this patch should be fine for
2.8 and we can revert it when MTTCG locking is merged.
Paolo
next prev parent reply other threads:[~2016-12-07 11:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 11:39 [Qemu-devel] [Bug 1647683] [NEW] Bad interaction between tb flushing & gdb stub Julian Brown
2016-12-06 11:46 ` [Qemu-devel] [Bug 1647683] " Julian Brown
2016-12-06 14:51 ` Alex Bennée
2016-12-06 12:34 ` [Qemu-devel] [Bug 1647683] [NEW] " Peter Maydell
2016-12-06 14:09 ` Peter Maydell
2016-12-06 14:51 ` [Qemu-devel] [PATCH] exec.c: simplify the breakpoint invalidation logic Alex Bennée
2016-12-06 14:54 ` Peter Maydell
2016-12-06 15:14 ` Alex Bennée
2016-12-06 16:09 ` Peter Maydell
2016-12-07 11:32 ` Paolo Bonzini [this message]
2016-12-06 15:43 ` [Qemu-devel] [Bug 1647683] Re: Bad interaction between tb flushing & gdb stub Julian Brown
2016-12-06 16:05 ` Julian Brown
2020-11-08 9:39 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246561763.1891130.1481110330525.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=1647683@bugs.launchpad.net \
--cc=alex.bennee@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.