From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Bug in gencmdlist.sh (or is it?)
Date: Sat, 04 Jul 2009 01:07:29 -0400 [thread overview]
Message-ID: <1246684049.2544.50.camel@mj> (raw)
In-Reply-To: <4A4C48CF.5090609@duboucher.eu>
On Thu, 2009-07-02 at 07:42 +0200, Duboucher Thomas wrote:
> No, it is not really urgent. As I said, I have already found a
> workaround. But based on Grub2 being a module-based project, I don't
> think an indentation-dependant parser is a good idea, nor is it robust.
I agree.
> >> I am working now with a small script
> >> written in Lua, but it is neither efficient, nor a good idea to add Lua
> >> as a dependency.
> >
> > I don't understand how this is related.
> >
>
> I have replaced gencmdlist.sh by a script in Lua that does the same, and
> can handle any kind of indentation - or at least the resulting file is
> identical even if I mess the indentation; but based on how and when I
> have writen it, well, I'm not very confident ;) -.
I think an improved approach would be one of those:
1) Make gencmdlist.sh call cpp with a special macro, that would expand
into something that can be reliably extracted by sed or grep and placed
into command.lst.
2) Use a macro to write the symbol into a special linker section.
gencmdlist.sh would read it to generate command.lst at the build time.
3) Use a macro to write the symbol into a special linker section.
grub-install would run a new utility to generate command.lst from the
modules in /boot/grub.
The later is very appealing, but it would be a big change in the way we
are doing things.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2009-07-04 5:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 22:34 Bug in gencmdlist.sh (or is it?) Duboucher Thomas
2009-07-02 1:14 ` Pavel Roskin
2009-07-02 5:42 ` Duboucher Thomas
2009-07-04 5:07 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246684049.2544.50.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.