From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] get rid of util/$(target_cpu)/$(platform)/misc.c
Date: Sat, 04 Jul 2009 16:21:48 -0400 [thread overview]
Message-ID: <1246738908.28782.3.camel@mj> (raw)
In-Reply-To: <20090704201109.GC27480@thorin>
On Sat, 2009-07-04 at 22:11 +0200, Robert Millan wrote:
> On Wed, Jul 01, 2009 at 11:14:55AM -0400, Pavel Roskin wrote:
> > On Mon, 2009-06-29 at 15:19 +0200, Robert Millan wrote:
> > > This patch gets rid of util/$(target_cpu)/$(platform)/misc.c by integrating
> > > them into util/misc.c.
> > >
> > > It paves the way for unification of grub-emu.
> >
> > The patch breaks compilation of any utilities other than grub-emu due to
> > undefined main_env :-(
>
> I can't reproduce this. In which port did you find it?
Actually, I applied that patch already. It was happening on i386-pc.
The code moved from util/$(target_cpu)/$(platform)/misc.c belongs to
grub-emu only.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2009-07-04 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 13:19 [PATCH] get rid of util/$(target_cpu)/$(platform)/misc.c Robert Millan
2009-07-01 13:01 ` Robert Millan
2009-07-01 15:14 ` Pavel Roskin
2009-07-04 20:11 ` Robert Millan
2009-07-04 20:21 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246738908.28782.3.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.