From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756283AbZGEWVu (ORCPT ); Sun, 5 Jul 2009 18:21:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753164AbZGEWVm (ORCPT ); Sun, 5 Jul 2009 18:21:42 -0400 Received: from hera.kernel.org ([140.211.167.34]:56344 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753324AbZGEWVl (ORCPT ); Sun, 5 Jul 2009 18:21:41 -0400 Subject: Re: [tip:x86/cleanups] x86: Clean up mtrr/cleanup.c From: Jaswinder Singh Rajput To: Thomas Gleixner Cc: Pekka Enberg , Ingo Molnar , Yinghai Lu , mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk, jaswinderrajput@gmail.com, akpm@linux-foundation.org, linux-tip-commits@vger.kernel.org In-Reply-To: References: <20090703164225.GA21447@elte.hu> <4A4FC5D0.6090000@kernel.org> <20090705002709.GA28424@elte.hu> <1246773777.2325.113.camel@jaswinder.satnam> <84144f020907050459x6a9a11fmf8f3050f085c8d85@mail.gmail.com> <1246799995.2442.7.camel@ht.satnam> Content-Type: text/plain Date: Mon, 06 Jul 2009 03:46:48 +0530 Message-Id: <1246832208.2398.48.camel@ht.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2009-07-05 at 22:11 +0200, Thomas Gleixner wrote: > Jaswinder, > > On Sun, 5 Jul 2009, Jaswinder Singh Rajput wrote: > > On Sun, 2009-07-05 at 14:59 +0300, Pekka Enberg wrote: > > > What's with the attitude? It's perfectly okay for a commiter to change > > > the patch as long as it's mentioned in the changelog. And that's > > > usually much faster to do that for minor issues rather than ping the > > > original submitter and wait for a resend. > > > > > > > I was also thankful to him but then he send me a long email and blamed > > me that I wasted his 6 hours to do further cleanup and solve bugs and > > other irrelevant things. > > Err, you managed to create _three_ bugs in your trivial cleanup > patches and that's not irrelevant at all. That's a sign of sloppiness > and a pretty good reason not to trust any of your patches at all. > > > And told me to not send further patches otherwise he will ignore it. > > Right, and he is correct about that. This is not the first time and > you have been asked to be more careful with your patches several times > in the last months. It's _you_ who is not listening and not caring at > all. > where is the list of bugs, I do not want to hear blah-blah. > > He is doing mistakes and blaming others and misusing maintainer-ship. > > Ingo did clean up _your_ mess and there was no mistake at all. He > blames _you_ correctly that _your_ trivial patches are buggy. > again blah-blah, where is the bug list. > There is no misuse at all. Ingo is doing what a responsible maintainer > does: reviewing patches and fixing them up when necessary. > Then he should do his work, no need to blame others. > His decision not to take any more cleanup patches from you is just the > result of your unwillingness to listen and to react on the requests > which were made to you from Ingo, myself and others. > I even do not want to do further clean-ups, because it is never ending task and it is totally personnel flavor. Thanks, -- JSR