From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Post <echo@echoreply.us>
Subject: Re: [PATCH] Fix xentop on pv-ops domain0
Date: Tue, 07 Jul 2009 00:02:09 +0800
Message-ID: <1246896129.5517.287.camel@localhost.localdomain>
References: <EADF0A36011179459010BDF5142A457501C9F46DA5@pdsmsx502.ccr.corp.intel.com>
	<200907061534.31677.Christoph.Egger@amd.com>
	<EADF0A36011179459010BDF5142A457501C9F46DBA@pdsmsx502.ccr.corp.intel.com>
	<200907061749.29633.Christoph.Egger@amd.com>
Reply-To: echo@echoreply.us
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200907061749.29633.Christoph.Egger@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: "Xu, Dongxiao" <dongxiao.xu@intel.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "keir.fraser@eu.citrix.com" <keir.fraser@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Hi,

On Mon, 2009-07-06 at 17:49 +0200, Christoph Egger wrote:
> This patch is good.
> 

The following is going to break xenstat on almost every forward port of
2.6.18.8 (including Andy's 2.6.30 vanilla port):


+       if (strncmp(system_info.release, "2.6.18.8-xen", 
+               sizeof("2.6.18.8-xen")) == 0)
+               sysfs_vbd_path = "/sys/devices/xen-backend/";
+       else
+               sysfs_vbd_path = "/sys/devices/";
+

I would really recommend considering just
using /sys/bus/xen-backend/devices, as Stephen noted.

Cheers,
--Tim