From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MNyhg-0003ts-E5 for mharc-grub-devel@gnu.org; Mon, 06 Jul 2009 20:38:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNyhe-0003tm-1W for grub-devel@gnu.org; Mon, 06 Jul 2009 20:38:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNyhZ-0003tO-Ho for grub-devel@gnu.org; Mon, 06 Jul 2009 20:38:33 -0400 Received: from [199.232.76.173] (port=36968 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNyhZ-0003tL-Bk for grub-devel@gnu.org; Mon, 06 Jul 2009 20:38:29 -0400 Received: from c60.cesmail.net ([216.154.195.49]:41446) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MNyhY-000189-E3 for grub-devel@gnu.org; Mon, 06 Jul 2009 20:38:29 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 06 Jul 2009 20:38:26 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 2BDF134C6A for ; Mon, 6 Jul 2009 20:46:41 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <2m2ai6-i7b.ln1@ppp121-45-136-118.lns11.adl6.internode.on.net> References: <4A51AE6A.6060708@impulze.org> <2m2ai6-i7b.ln1@ppp121-45-136-118.lns11.adl6.internode.on.net> Content-Type: text/plain Date: Mon, 06 Jul 2009 20:38:24 -0400 Message-Id: <1246927104.31361.43.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Caseless UUID comparsion in search command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2009 00:38:34 -0000 On Tue, 2009-07-07 at 05:46 +0930, Arthur Marsh wrote: > Daniel Mierswa wrote, on 06/07/09 17:27: > > Just like some time ago in search_fs_uuid() the search_fs() function of > > search also needs to be caseless when comparing UUIDs, for some reason > > GRUB2 didn't find my UUID although I entered it as reported by blkid. To > > be on the safe side, just use strncasecmp. :) Patch against git master > > and ChangeLog attached. I await your feedback. :-) > > Thanks, I tried it, but still didn't get any further with the following bug: > > https://savannah.gnu.org/bugs/?26834 search for UUID fails with > dedicated /boot filesystem on disk larger than what BIOS sees That's because ext3 UUID is lower case, so case sensitivity shouldn't be an issue. While trying to reproduce the issue, I found and fixed a memory corruption bug affecting arguments of long options, but your case is not affected. You would only be affected it you use "--set=root" instead of just "--set". I could not reproduce the problem by setting up a separate partition, and by instructing qemu to access part of the device. I don't think GRUB would fail to find a device by it's UUID if it can load the kernel from it. It's more like the UUID from grub.cfg doesn't match the one GRUB sees. Please show the output of "ls -l (hd0,1)" on the GRUB command line and the output of "tune2fs -l /dev/hda1 |grep UUID" in Linux. -- Regards, Pavel Roskin