From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mark Nelson <markn@au1.ibm.com>
Cc: "Kári Davíðsson" <kari.davidsson@marel.com>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
"Kumar Gala" <galak@gate.crashing.org>
Subject: Re: dma_ops->map_page == NULL
Date: Tue, 07 Jul 2009 21:08:25 +1000 [thread overview]
Message-ID: <1246964905.6066.41.camel@pasglop> (raw)
In-Reply-To: <200907071015.24097.markn@au1.ibm.com>
On Tue, 2009-07-07 at 10:15 +1000, Mark Nelson wrote:
>
> When the 32 and 64bit DMA code was merged in .28 , map_/unmap_page() was
> added in favour of map_/unmap_single() (which was later removed in .29)
> so you'll have to replace your calls to dma_map_single() with
> dma_map_page(). Just pass it the page and offset rather than the address.
Wait a minute ... dma_map_single() should still work, it will just call
dma_map_page() underneath. All dma_ops should have a ->map page
callback.
Do you have any dma_ops set for your device at all ? I wonder how we
set the dma_ops for platform devices nowadays ... We use to have this
fallback to direct ops when the dma_ops are NULL but that is gone and
I see no suitable replacement to set them on platform devices for
embedded archs ... oops...
Kumar, Becky, what's the situation there ?
Cheers,
Ben.
next prev parent reply other threads:[~2009-07-07 11:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 17:51 dma_ops->map_page == NULL Kári Davíðsson
2009-07-07 0:15 ` Mark Nelson
2009-07-07 11:08 ` Benjamin Herrenschmidt [this message]
2009-07-07 14:37 ` Kumar Gala
2009-07-07 15:24 ` Kári Davíðsson
2009-07-07 15:45 ` Kumar Gala
2009-07-07 15:49 ` Becky Bruce
2009-07-08 0:44 ` Mark Nelson
2009-07-07 12:50 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246964905.6066.41.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=galak@gate.crashing.org \
--cc=kari.davidsson@marel.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=markn@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.