All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Joao Correia <joaomiguelcorreia@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Amerigo Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH 3/3] Increase lockdep limits: MAX_LOCKDEP_CHAINS_BITS
Date: Tue, 07 Jul 2009 17:32:51 +0200	[thread overview]
Message-ID: <1246980771.9777.4.camel@twins> (raw)
In-Reply-To: <a5d9929e0907070825p78c1e527ud8f8d047767f621e@mail.gmail.com>

On Tue, 2009-07-07 at 16:25 +0100, Joao Correia wrote:
> (Applies to current Linus tree, as of 2.6.31-rc2)
> 
> A third limit becomes apparent as being too low after raising
> MAX_STACK_TRACE_ENTRIES and MAX_LOCK_DEPTH, although this one is more
> elusive to trigger.

Hrmm, I really wonder what takes all these chains, I never run into this
stuff. We recently fixed the dma-debug code to generate less classes,
could there be more such bugs?

> Signed-off-by: Joao Correia <joaomiguelcorreia@gmail.com>
> 
> ---
>  kernel/lockdep_internals.h | 2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/lockdep_internals.h b/kernel/lockdep_internals.h
> index 699a2ac..93af1f1 100644
> --- a/kernel/lockdep_internals.h
> +++ b/kernel/lockdep_internals.h
> @@ -56,7 +56,7 @@ enum {
>   */
>  #define MAX_LOCKDEP_ENTRIES    16384UL
> 
> -#define MAX_LOCKDEP_CHAINS_BITS        15
> +#define MAX_LOCKDEP_CHAINS_BITS        16
>  #define MAX_LOCKDEP_CHAINS     (1UL << MAX_LOCKDEP_CHAINS_BITS)
> 
>  #define MAX_LOCKDEP_CHAIN_HLOCKS (MAX_LOCKDEP_CHAINS*5)
> ---


  reply	other threads:[~2009-07-07 15:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-07 15:25 [PATCH 3/3] Increase lockdep limits: MAX_LOCKDEP_CHAINS_BITS Joao Correia
2009-07-07 15:32 ` Peter Zijlstra [this message]
2009-07-08 18:34 ` Peter Zijlstra
2009-07-08 19:32   ` Joao Correia
2009-07-08 19:33     ` Joao Correia
2009-07-10 20:34       ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246980771.9777.4.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=joaomiguelcorreia@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.