From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MOH44-000230-Gq for mharc-grub-devel@gnu.org; Tue, 07 Jul 2009 16:14:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOH43-00022F-CR for grub-devel@gnu.org; Tue, 07 Jul 2009 16:14:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOH3y-0001zq-Mq for grub-devel@gnu.org; Tue, 07 Jul 2009 16:14:54 -0400 Received: from [199.232.76.173] (port=38621 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOH3y-0001zf-II for grub-devel@gnu.org; Tue, 07 Jul 2009 16:14:50 -0400 Received: from c60.cesmail.net ([216.154.195.49]:16024) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MOH3x-00043w-P8 for grub-devel@gnu.org; Tue, 07 Jul 2009 16:14:50 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 07 Jul 2009 16:14:48 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 2A28334C6A for ; Tue, 7 Jul 2009 16:23:10 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090707184252.GC14645@thorin> References: <20090706211303.23809.9322.stgit@mj.roinet.com> <20090707184252.GC14645@thorin> Content-Type: text/plain Date: Tue, 07 Jul 2009 16:14:46 -0400 Message-Id: <1246997686.3393.33.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Refactor commands/search.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2009 20:14:55 -0000 On Tue, 2009-07-07 at 20:42 +0200, Robert Millan wrote: > I'd suggest making this clearer by eithe explicitly checking for > SEARCH_XXX or otherwise put a comment after the else. Done. Committed. -- Regards, Pavel Roskin