From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MOHdv-0003gH-6g for mharc-grub-devel@gnu.org; Tue, 07 Jul 2009 16:51:59 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOHdt-0003g7-9s for grub-devel@gnu.org; Tue, 07 Jul 2009 16:51:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOHdn-0003fn-Op for grub-devel@gnu.org; Tue, 07 Jul 2009 16:51:55 -0400 Received: from [199.232.76.173] (port=51635 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOHdn-0003fk-Iu for grub-devel@gnu.org; Tue, 07 Jul 2009 16:51:51 -0400 Received: from c60.cesmail.net ([216.154.195.49]:50024) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MOHdm-0002XB-Ru for grub-devel@gnu.org; Tue, 07 Jul 2009 16:51:51 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 07 Jul 2009 16:51:48 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 0051034C6A for ; Tue, 7 Jul 2009 17:00:10 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090707195153.GA10993@thorin> References: <20090627112521.GA28637@thorin> <20090707195153.GA10993@thorin> Content-Type: text/plain Date: Tue, 07 Jul 2009 16:51:47 -0400 Message-Id: <1246999907.3393.43.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] use ljmp to reboot (Re: at_keyboard flush on i386-qemu) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2009 20:51:57 -0000 On Tue, 2009-07-07 at 21:51 +0200, Robert Millan wrote: > I think we should just jump to 0xffff0 to reboot. I didn't know back when I > wrote reboot.c, but this is supposedly more reliable since we're jumping to > code in ROM which hasn't been overwritten (kern/i386/pc/startup.S uses the > same trick for its own grub_reboot()). I have no objections about the patch except that it breaks compilation for i386-coreboot: kernel_img-symlist.o:(.data+0x3b4): undefined reference to `grub_reboot' Perhaps kern/i386/reboot.c should be kept, but the code should only be enabled for coreboot. By the way, GRUB_MACHINE_LINUXBIOS should be renamed to GRUB_MACHINE_COREBOOT. Its use in loader/multiboot_loader.c is dubious. -- Regards, Pavel Roskin