From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: grub-install --root-directory=/mnt /dev/sda1 fails
Date: Wed, 08 Jul 2009 16:16:33 +0200 [thread overview]
Message-ID: <1247062593.10027.0.camel@fz.local> (raw)
In-Reply-To: <20090704200908.GA27480@thorin>
Am Samstag, den 04.07.2009, 22:09 +0200 schrieb Robert Millan:
> On Wed, Jul 01, 2009 at 04:33:25PM +0200, Felix Zielcke wrote:
> > Am Montag, den 01.06.2009, 21:39 +0200 schrieb Felix Zielcke:
> > > Am Mittwoch, den 06.05.2009, 17:12 +0200 schrieb Vladimir 'phcoder'
> > > Serbinenko:
> > > > Don't we already have a function which transforms host directory into
> > > > grub
> > > > directory? AFAIR we have.
> > >
> > > There's just the shell function in grub-mkconfig_lib.in
> > > Here's now a patch wich implements it in util/hostdisk.c and gets used
> > > for core_path_dev in setup ().
> > > But it doestn't work with symlinks.
> > > readlink () can only be used if the file pointed to is a symlink, not if
> > > a symlink is somewhere in between.
> > > coreutils where the readlink binary is from is GPL 3+ but the function
> > > for it uses hash tables and it seems like it would be too much code to
> > > copy just for this.
> >
> > So what do we do know about this problem?
> > We could just assume that the directory given with grub-setup
> > --directory is already the real absolute path and just use the stat
> > magic to make it relative.
> > Or we use realpath() if avaible to get the real one.
> > And on systems not having it, like mingw we could just assume that it's
> > already relative and just return the path given.
> > Or is there some other way this bug can be fixed?
>
> I just looked into this, and I don't think there's any real problem that
> needs fixing. The "workaround" is just a red herring, it works for him by
> pure chance.
>
> See:
>
> http://savannah.gnu.org/bugs/index.php?26924
I think I tested this and the root device was set correctly, so it
looked at the right device for the core.img
--
Felix Zielcke
prev parent reply other threads:[~2009-07-08 14:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 14:31 grub-install --root-directory=/mnt /dev/sda1 fails Felix Zielcke
2009-05-06 15:12 ` Vladimir 'phcoder' Serbinenko
2009-06-01 19:39 ` Felix Zielcke
2009-06-08 21:20 ` [PATCH] " Felix Zielcke
2009-06-09 21:51 ` Vladimir 'phcoder' Serbinenko
2009-06-10 23:00 ` Felix Zielcke
2009-06-11 23:21 ` Felix Zielcke
2009-06-11 23:25 ` Felix Zielcke
2009-06-12 10:28 ` Felix Zielcke
2009-06-12 16:21 ` Pavel Roskin
2009-06-12 16:33 ` Felix Zielcke
2009-07-01 14:33 ` Felix Zielcke
2009-07-04 20:09 ` Robert Millan
2009-07-08 14:16 ` Felix Zielcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247062593.10027.0.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.