All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix incorrect alignment in Marvell BT-over-SDIO driver
Date: Wed, 08 Jul 2009 11:54:16 -0700	[thread overview]
Message-ID: <1247079256.9709.2.camel@localhost.localdomain> (raw)
In-Reply-To: <1247078654-8666-1-git-send-email-bzhao@marvell.com>

Hi Bing,

> The driver uses "u32" for alignment check and calculation which
> works only on 32-bit system. It will crash the 64-bit system.
> Replace "u32" with "unsigned long" to fix this issue.

I pushed that patch into the bluetooth-mrvl-2.6 tree now.

However I am pretty sure that are better "Linux" ways on handling the
alignment for the SKBs.

Regards

Marcel



  reply	other threads:[~2009-07-08 18:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-08 18:44 [PATCH] Bluetooth: Fix incorrect alignment in Marvell BT-over-SDIO driver Bing Zhao
2009-07-08 18:54 ` Marcel Holtmann [this message]
2009-07-13 18:06   ` Bing Zhao
2009-07-14  2:26     ` Marcel Holtmann
2009-07-14  4:20       ` Bing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247079256.9709.2.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=bzhao@marvell.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.