From: Dave Wysochanski <dwysocha@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Do not count VG_GLOBAL to lock_count.
Date: Fri, 10 Jul 2009 12:09:23 -0400 [thread overview]
Message-ID: <1247242163.2462.10.camel@f10-node1> (raw)
In-Reply-To: <4A574BE0.70704@redhat.com>
On Fri, 2009-07-10 at 16:10 +0200, Milan Broz wrote:
> Do not count VG_GLOBAL to lock_count.
>
This description is misleading - it's not the count that matters its the
flag _vg_write_lock_held, and that's set based on the lock type:
/* We don't bother to reset this until all VG locks are dropped */
if ((flags & LCK_TYPE_MASK) == LCK_WRITE)
_vg_write_lock_held = 1;
else if (!_vg_lock_count)
_vg_write_lock_held = 0;
}
Wouldn't a better fix just be changing pvscan and vgscan to use
LCK_VG_READ instead of LCK_VG_WRITE since they are not updating
metadata? Or is there a problem with doing that?
I guess in general I don't like the idea of affecting the count. Unless
of course we want to call "VG_GLOBAL" not really a vg lock. But then
the naming seems inconsistent.
next prev parent reply other threads:[~2009-07-10 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 14:10 [PATCH] Do not count VG_GLOBAL to lock_count Milan Broz
2009-07-10 16:09 ` Dave Wysochanski [this message]
2009-07-13 15:42 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247242163.2462.10.camel@f10-node1 \
--to=dwysocha@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.