From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: Move the sleeping while atomic checks early in cond_resched()
Date: Fri, 10 Jul 2009 20:13:42 +0200 [thread overview]
Message-ID: <1247249622.6042.7.camel@laptop> (raw)
In-Reply-To: <20090710180801.GA5271@nowhere>
On Fri, 2009-07-10 at 20:08 +0200, Frederic Weisbecker wrote:
> > Right, how about renaming these to _cond_resched_{lock,softirq}, and
> > added a __might_sleep() definition for !DEBUG_SPINLOCK_SLEEP and add
> > macro wrappers to sched.c for these two as well?
>
> I did that first but thought that might_sleep() would fail in a spinlock
> held or softirq context, right?
Ah, right.. maybe we can add a preempt_count_offset parameter to
__might_sleep() such that it will compensate for the pending
spin_unlock()/local_bh_enable().
next prev parent reply other threads:[~2009-07-10 18:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 14:49 [PATCH 1/2] sched: Drop the need_resched() loop from cond_resched() Frederic Weisbecker
2009-07-10 14:49 ` [PATCH 2/2] sched: Move the sleeping while atomic checks early in cond_resched() Frederic Weisbecker
2009-07-10 14:59 ` Peter Zijlstra
2009-07-10 15:08 ` Frederic Weisbecker
2009-07-10 15:12 ` Peter Zijlstra
2009-07-10 16:10 ` Ingo Molnar
2009-07-10 17:14 ` [PATCH] " Frederic Weisbecker
2009-07-10 17:43 ` Peter Zijlstra
2009-07-10 18:08 ` Frederic Weisbecker
2009-07-10 18:13 ` Peter Zijlstra [this message]
2009-07-10 18:29 ` Frederic Weisbecker
2009-07-10 15:00 ` [PATCH 1/2] sched: Drop the need_resched() loop from cond_resched() Peter Zijlstra
2009-07-10 15:17 ` Arnd Bergmann
2009-07-10 15:24 ` Frederic Weisbecker
2009-07-10 15:35 ` Arnd Bergmann
2009-07-10 15:50 ` Frederic Weisbecker
2009-07-10 16:11 ` Ingo Molnar
2009-07-10 16:26 ` Frederic Weisbecker
2009-07-10 17:23 ` [PATCH] sched: Remove obsolete comment in __cond_resched() Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247249622.6042.7.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.