From: Pavel Roskin <proski@gnu.org>
To: Theodore Tso <tytso@mit.edu>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: ext4_mb_initialize_context() forgets to initialize some fields
Date: Mon, 13 Jul 2009 17:27:07 -0400 [thread overview]
Message-ID: <1247520427.3865.1.camel@mj> (raw)
In-Reply-To: <20090713134653.GD12833@mit.edu>
On Mon, 2009-07-13 at 09:46 -0400, Theodore Tso wrote:
> On Fri, Jul 10, 2009 at 03:59:06PM -0500, Eric Sandeen wrote:
> >
> > At this point I think we are initializing almost all of the 22
> > allocation context members and 16 of those are 0/NULL; perhaps it'd be
> > simpler and/or more efficient to just start with a memset(0), but either
> > way.
>
> Agreed, it should be more efficient. This is the patch which I just
> added to the ext4 patch queue.
Thanks! I confirm that kmemcheck is silent about ext4 after this patch
is applied.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2009-07-13 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 20:47 [PATCH] ext4: ext4_mb_initialize_context() forgets to initialize some fields Pavel Roskin
2009-07-10 20:59 ` Eric Sandeen
2009-07-13 13:46 ` Theodore Tso
2009-07-13 21:27 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247520427.3865.1.camel@mj \
--to=proski@gnu.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.