From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MQVGm-0006u2-NJ for mharc-grub-devel@gnu.org; Mon, 13 Jul 2009 19:49:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MQVGk-0006tF-OY for grub-devel@gnu.org; Mon, 13 Jul 2009 19:49:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MQVGg-0006oT-7T for grub-devel@gnu.org; Mon, 13 Jul 2009 19:49:14 -0400 Received: from [199.232.76.173] (port=33484 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MQVGg-0006oL-3j for grub-devel@gnu.org; Mon, 13 Jul 2009 19:49:10 -0400 Received: from c60.cesmail.net ([216.154.195.49]:22255) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MQVGf-0006aw-G4 for grub-devel@gnu.org; Mon, 13 Jul 2009 19:49:09 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 13 Jul 2009 19:49:08 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 241E334C88 for ; Mon, 13 Jul 2009 19:58:24 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Mon, 13 Jul 2009 19:49:06 -0400 Message-Id: <1247528946.3865.23.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] osdetect.lua improvement X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2009 23:49:14 -0000 On Sat, 2009-07-11 at 13:58 +0800, Bean wrote: > Hi, > > This patch would check for drive number and use drivemap to map disks, > this is required to boot DOS/Windows from secondary drive. It also > change commands like root (hd0,0) to root=hd0,0 (I remember someone > want to remove the root command ?) Looks good to me. Actually, the logic should be changed so that we don't add "chainloader" and "drivemap" for Linux and FreeBSD, but it could be a separate patch. What's really needed in osdetect.lua is elimination of partitions with invalid bootloader signatures. If the first sector doesn't end with 0x55 0xaa, the partition should not appear with the "chainloader" command. For "Other OS", it would be nice to specify the partition in the menu title. Actually, maybe we should provide partitions for all names. Since osdetect.lua scans all drives, it would be nice to distinguish Linux 2.6.30 that boots Fedora from Linux 2.6.30 that boots SUSE. -- Regards, Pavel Roskin