From: Daniel Walker <dwalker@fifo99.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Brian Swetland <swetland@google.com>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: HTC: touchscreen driver
Date: Mon, 13 Jul 2009 18:48:07 -0700 [thread overview]
Message-ID: <1247536087.31854.39.camel@desktop> (raw)
In-Reply-To: <20090713220726.GA28375@elf.ucw.cz>
On Tue, 2009-07-14 at 00:07 +0200, Pavel Machek wrote:
> On Mon 2009-07-13 22:57:49, Pavel Machek wrote:
> > Hi!
> >
> > I'm looking at synaptic touchscreen driver... who should be listed as
> > an author?
> >
> > Changes I have so far are...
> >
> > checkpatch only has minor complains -- lines over 80 characters -- but
> > the code is _way_ too deeply nested with way too little functions.
>
> Here's better cleanup. But... some functions are still _way_ too big.
>
I'd put the nesting removal into another patch .. It makes reviewing
more clear, your first patch was already fairly busy .. It would also
make a bisect more fine grained if it lands on one of your patches.
Daniel
next prev parent reply other threads:[~2009-07-14 1:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090710084323.GA6522@elf.ucw.cz>
[not found] ` <a55d774e0907100155m25366994pe9ec5d0f5f868818@mail.gmail.com>
[not found] ` <20090710103243.GB7789@elf.ucw.cz>
[not found] ` <a55d774e0907100431j3fdc4671i6b185019594367fa@mail.gmail.com>
[not found] ` <20090713202302.GC2569@elf.ucw.cz>
2009-07-13 20:57 ` HTC: touchscreen driver Pavel Machek
2009-07-13 22:07 ` Pavel Machek
2009-07-14 1:29 ` Arve Hjønnevåg
2009-07-14 1:44 ` Joe Perches
2009-07-14 9:46 ` Pavel Machek
2009-07-15 19:05 ` Frank Rowand
2009-07-14 9:23 ` Pavel Machek
2009-07-14 9:46 ` Pavel Machek
2009-07-14 22:07 ` Arve Hjønnevåg
2009-07-14 22:16 ` Pavel Machek
2009-07-14 22:45 ` Arve Hjønnevåg
2009-07-15 6:21 ` Trilok Soni
2009-07-15 6:48 ` Arve Hjønnevåg
2009-07-19 21:23 ` Pavel Machek
2009-07-20 3:43 ` Arve Hjønnevåg
2009-07-20 10:47 ` Pavel Machek
2009-07-21 10:11 ` Pavel Machek
2009-07-22 1:12 ` Arve Hjønnevåg
2009-07-23 21:25 ` Pavel Machek
2009-07-24 0:11 ` Arve Hjønnevåg
2009-07-27 23:14 ` Pavel Machek
2009-07-27 23:38 ` Arve Hjønnevåg
2009-07-14 10:02 ` Pavel Machek
2009-07-14 1:48 ` Daniel Walker [this message]
2009-07-14 6:47 ` Trilok Soni
2009-07-14 0:17 ` Brian Swetland
2009-07-14 9:47 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247536087.31854.39.camel@desktop \
--to=dwalker@fifo99.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.