All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: linux-kernel@vger.kernel.org
Cc: uclinux-dist-devel@blackfin.uclinux.org,
	Sonic Zhang <sonic.zhang@analog.com>,
	David Howells <dhowells@redhat.com>
Subject: [PATCH/RFC] NOMMU: drop page cache whenever any alloc fails due to low memory
Date: Tue, 14 Jul 2009 10:22:37 -0400	[thread overview]
Message-ID: <1247581357-20068-1-git-send-email-vapier@gentoo.org> (raw)

From: Sonic Zhang <sonic.zhang@analog.com>

Since no-mmu systems tend to be memory constrained, we want to drop all
of the page cache whenever memory gets low.  The only other option is to
invoke the oom killer, and clearly that's not ideal.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
CC: David Howells <dhowells@redhat.com>
---
 fs/drop_caches.c   |    2 +-
 include/linux/mm.h |    1 +
 mm/page_alloc.c    |    4 ++++
 3 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/fs/drop_caches.c b/fs/drop_caches.c
index a2edb79..51f097d 100644
--- a/fs/drop_caches.c
+++ b/fs/drop_caches.c
@@ -33,7 +33,7 @@ static void drop_pagecache_sb(struct super_block *sb)
 	iput(toput_inode);
 }
 
-static void drop_pagecache(void)
+void drop_pagecache(void)
 {
 	struct super_block *sb;
 
diff --git a/include/linux/mm.h b/include/linux/mm.h
index ba3a7cb..46084c4 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1293,6 +1293,7 @@ int drop_caches_sysctl_handler(struct ctl_table *, int, struct file *,
 					void __user *, size_t *, loff_t *);
 unsigned long shrink_slab(unsigned long scanned, gfp_t gfp_mask,
 			unsigned long lru_pages);
+void drop_pagecache(void);
 
 #ifndef CONFIG_MMU
 #define randomize_va_space 0
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index caa9268..246d381 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1772,6 +1772,10 @@ restart:
 		goto got_pg;
 
 rebalance:
+#ifndef CONFIG_MMU
+	drop_pagecache();
+#endif
+
 	/* Allocate without watermarks if the context allows */
 	if (alloc_flags & ALLOC_NO_WATERMARKS) {
 		page = __alloc_pages_high_priority(gfp_mask, order,
-- 
1.6.3.3


             reply	other threads:[~2009-07-14 14:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14 14:22 Mike Frysinger [this message]
2009-07-14 14:30 ` [PATCH/RFC] NOMMU: drop page cache whenever any alloc fails due to low memory Peter Zijlstra
2009-07-15  3:29   ` Zhang, Sonic
2009-07-15  6:38     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247581357-20068-1-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sonic.zhang@analog.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.