From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MQnAR-0005XN-L3 for mharc-grub-devel@gnu.org; Tue, 14 Jul 2009 14:55:55 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MQnAP-0005Wn-Nk for grub-devel@gnu.org; Tue, 14 Jul 2009 14:55:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MQnAK-0005T1-EJ for grub-devel@gnu.org; Tue, 14 Jul 2009 14:55:53 -0400 Received: from [199.232.76.173] (port=54845 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MQnAK-0005Sk-6o for grub-devel@gnu.org; Tue, 14 Jul 2009 14:55:48 -0400 Received: from c60.cesmail.net ([216.154.195.49]:14736) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MQnAJ-0000KY-OD for grub-devel@gnu.org; Tue, 14 Jul 2009 14:55:48 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 14 Jul 2009 14:55:45 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id B125034C6D for ; Tue, 14 Jul 2009 15:05:08 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090714173706.GB10523@thorin> References: <4A55AE37.1060605@zetam.org> <20090710173647.GH17114@thorin> <8330AAA8-F56B-43FF-A11B-C75952FB67B3@zetam.org> <20090712092107.ausjawz604ksgkcg-cebfxv@webmail.spamcop.net> <20090714173706.GB10523@thorin> Content-Type: text/plain Date: Tue, 14 Jul 2009 14:55:44 -0400 Message-Id: <1247597744.25012.1.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] unused constants in i386/boot.h X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2009 18:55:53 -0000 On Tue, 2009-07-14 at 19:37 +0200, Robert Millan wrote: > On Sun, Jul 12, 2009 at 09:21:07AM -0400, Pavel Roskin wrote: > > Quoting Yves Blusseau : > > > >>> As long as boot/i386/pc/boot.S has the variables whose offset these macros > >>> are describing, I think it's fine to keep them. > > > > I'd rather not keep the macros that are not used outside boot.S. They > > give a wrong impression that somebody somewhere needs to know that > > offset. > > Ok, let's remove them. I don't feel strongly about it. I'm working on a patch series that would remove unnecessary stuff and widen the BPB. -- Regards, Pavel Roskin