From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH 7/7] RFC: Use correct addresses, eliminate manual relocations
Date: Wed, 15 Jul 2009 11:33:22 -0400 [thread overview]
Message-ID: <1247672002.4177.19.camel@mj> (raw)
In-Reply-To: <20090715010055.17865.4764.stgit@mj.roinet.com>
On Tue, 2009-07-14 at 21:00 -0400, Pavel Roskin wrote:
> ChangeLog:
>
> * boot/i386/pc/boot.S: Declare 0x0-0x7c00 as a discardable .bss
> segment. Eliminate ABS, rely on the assembler knowing correct
> addresses. Eliminate .bss segment for the kernel, use direct
> jump to the kernel address.
I managed to install a Darwin cross-compiler, and it turn out it won't
accept .bss in assembler files. Using real addresses would be very,
very nice, but we'll need to find a portable way. Maybe grub-macho2img
should be taught to cut away sections filled with zeroes.
So patches 5 and 7 are dropped for now. Patches 1-4 and 6 have been
applied. Installation on FAT32 is safe now. The "Hard Disk" message
has been preserved, so it can be shortened later if the real need
arises.
That said, using direct jump to 0x8000 would save 3 bytes, and then we
can save 2 bytes by taking an unconditional jump from the "disk check"
code and reverting the logic. And maybe we could save 1 byte by yanking
"cli" as writing to %ss disables interrupts until the next instruction.
While testing the patches in qemu, I've seen some error messages and
found that they should be followed by a new line, as qemu adds its own
error message.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-07-15 15:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 1:00 [PATCH 1/7] Make boot/i386/pc/boot.S safer to modify Pavel Roskin
2009-07-15 1:00 ` [PATCH 2/7] Remove unused version information from boot/i386/pc/boot.S Pavel Roskin
2009-07-15 1:00 ` [PATCH 3/7] Eliminate kernel_segment Pavel Roskin
2009-07-16 15:45 ` Robert Millan
2009-07-15 1:00 ` [PATCH 4/7] Eliminate kernel_address Pavel Roskin
2009-07-16 15:52 ` Robert Millan
2009-07-15 1:00 ` [PATCH 5/7] Add newline after "Error" in bootsector Pavel Roskin
2009-07-15 1:00 ` [PATCH 6/7] Increase BPB size to accommodate FAT32 Pavel Roskin
2009-07-15 1:00 ` [PATCH 7/7] RFC: Use correct addresses, eliminate manual relocations Pavel Roskin
2009-07-15 15:33 ` Pavel Roskin [this message]
2009-07-15 22:41 ` Vladimir 'phcoder' Serbinenko
2009-07-15 23:40 ` Pavel Roskin
2009-07-16 3:44 ` Pavel Roskin
2009-07-16 15:36 ` Vladimir 'phcoder' Serbinenko
2009-07-16 15:43 ` [PATCH 1/7] Make boot/i386/pc/boot.S safer to modify Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247672002.4177.19.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.