From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MRokR-0001wR-2S for mharc-grub-devel@gnu.org; Fri, 17 Jul 2009 10:49:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRokO-0001vH-O6 for grub-devel@gnu.org; Fri, 17 Jul 2009 10:49:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRokL-0001tD-0S for grub-devel@gnu.org; Fri, 17 Jul 2009 10:49:16 -0400 Received: from [199.232.76.173] (port=37957 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRokK-0001t5-Kk for grub-devel@gnu.org; Fri, 17 Jul 2009 10:49:12 -0400 Received: from c60.cesmail.net ([216.154.195.49]:32620) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MRokK-00023c-2p for grub-devel@gnu.org; Fri, 17 Jul 2009 10:49:12 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 17 Jul 2009 10:49:10 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 9F39234C6A; Fri, 17 Jul 2009 10:58:58 -0400 (EDT) From: Pavel Roskin To: Vladimir 'phcoder' Serbinenko , grub-devel@gnu.org In-Reply-To: References: <20090716203709.cps5jkp0oo0wws8w-cebfxv@webmail.spamcop.net> Content-Type: text/plain Date: Fri, 17 Jul 2009 10:49:09 -0400 Message-Id: <1247842149.25608.44.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Subject: Re: [PATCH] enable buildable targets by default X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2009 14:49:17 -0000 On Fri, 2009-07-17 at 11:21 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Fri, Jul 17, 2009 at 2:37 AM, Pavel Roskin wrote: > > Quoting Vladimir 'phcoder' Serbinenko : > > > >> comitted > > > > I wish I had time to review it :-( > > > > I have fixed the easy stuff (spelling, wrong variables, use of "$no", > Thanks > > use of "-c" in CFLAGS). > This was done on purpose so that we don't need gcc-multilib for tests AC_COMPILE_IFELSE already means that the program is compiled but not linked. I tried removing glibc-devel.i586, and everything is still OK. > > The remaining problem is that efiemu only compiles on > > i386-pc, but configure not only checks for the necessary flags on other > > platforms, but also announces that it will be built. > Actually the check is necessary only for efiemu64. Perhaps we should > always build efiemu32 and make grub fallback to efiemu32 even on > 64-bit platform if efiemu64 is unavailable. Then enable-efiemu would > be renamed to enable-efiemu64 That's a separate issue. And then there is a problem that efiemu is undocumented, so users cannot decide whether they need it or not. > > Perhaps we can compile efiemu on i386 and x86_64, but certainly not on > > powerpc and sparc. > > > > Once everything is compiled by default, some of the configure options become > > less meaningful, so we can consider removing them. It's not so important to > > disable some feature as it is to enable it. > IMO if user does some not so useful things it's his problems. It's not > a reason to limit flexibility I think we should provide meaningful options. For example, an option to disable compiling debugging tools, or an option to add extra sanity checks. An option to disable efiemu64 is not meaningful for someone who doesn't know how to use efiemu64. -- Regards, Pavel Roskin