From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Ingo Molnar <mingo@elte.hu>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] kmemleak: Scan all thread stacks
Date: Fri, 17 Jul 2009 19:01:09 +0200 [thread overview]
Message-ID: <1247850069.6522.91.camel@laptop> (raw)
In-Reply-To: <1247849826.6313.64.camel@pc1117.cambridge.arm.com>
On Fri, 2009-07-17 at 17:57 +0100, Catalin Marinas wrote:
> On Fri, 2009-07-17 at 18:43 +0200, Ingo Molnar wrote:
> > * Catalin Marinas <catalin.marinas@arm.com> wrote:
> > > 2. Is it safe to use rcu_read_lock() and task_lock() when scanning the
> > > corresponding kernel stack (thread_info structure)? The loop doesn't
> > > do any modification to the task list. The reason for this is to
> > > allow kernel preemption when scanning the stacks.
> >
> > you cannot generally preempt while holding the RCU read-lock.
>
> This may work with rcupreempt enabled. But, with classic RCU is it safe
> to call schedule (or cond_resched) while holding the RCU read-lock?
No.
next prev parent reply other threads:[~2009-07-17 17:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 9:38 [RFC PATCH] kmemleak: Scan all thread stacks Catalin Marinas
2009-07-17 16:43 ` Ingo Molnar
2009-07-17 16:57 ` Catalin Marinas
2009-07-17 17:01 ` Peter Zijlstra [this message]
2009-07-20 10:09 ` Catalin Marinas
2009-07-22 16:18 ` Paul E. McKenney
2009-07-22 17:03 ` Catalin Marinas
2009-07-22 20:16 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247850069.6522.91.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.