All of lore.kernel.org
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@tglx.de>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Duplicate vsyscall/vdso gettimeofday implementations on x86_64
Date: Fri, 17 Jul 2009 15:02:10 -0700	[thread overview]
Message-ID: <1247868130.8334.40.camel@localhost.localdomain> (raw)

Hey Andi, Ingo, Thomas,
	I ran across an oddity recently in the x86_64 vsyscall code.
Specifically I was looking at the vsyscall clock_gettime()
implementation in arch/x86/vdso/vclock_gettime.c, and noticed there is a
vsyscall gettimeofday implementation there too! This seems to duplicate
the do_vgettimeofday implementation in arch/x86/kernel/vsyscall_64.c

I think the implementation in vclock_gettime.c is nice, as it mostly
reuses the clock_gettime() code, but I don't think it actually gets
called.

I'm a little worried about just switching it out, and cleaning it up, as
I don't know enough yet about how the vgettimeofday is called from glibc
(I thought it was a static "jump to this page and run" mapping).

Andi: You wrote the vclock_gettime.c, do you have any pointers about
where you were going with this? Is there a reason you didn't clean it up
when you implemented it originally?

thanks
-john



             reply	other threads:[~2009-07-17 22:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 22:02 john stultz [this message]
2009-07-17 22:12 ` Duplicate vsyscall/vdso gettimeofday implementations on x86_64 Andi Kleen
2009-07-17 22:54   ` john stultz
2009-07-18  6:07     ` Andi Kleen
2009-07-18  6:50       ` Andi Kleen
2009-07-18 22:03       ` john stultz
2009-07-19  7:22         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247868130.8334.40.camel@localhost.localdomain \
    --to=johnstul@us.ibm.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@tglx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.