From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MSIo1-00068Q-Qg for mharc-grub-devel@gnu.org; Sat, 18 Jul 2009 18:55:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MSInz-00066c-6w for grub-devel@gnu.org; Sat, 18 Jul 2009 18:54:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MSInt-00063O-To for grub-devel@gnu.org; Sat, 18 Jul 2009 18:54:57 -0400 Received: from [199.232.76.173] (port=42975 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSInt-00063D-JU for grub-devel@gnu.org; Sat, 18 Jul 2009 18:54:53 -0400 Received: from c60.cesmail.net ([216.154.195.49]:15595) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MSInt-0003RU-2f for grub-devel@gnu.org; Sat, 18 Jul 2009 18:54:53 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 18 Jul 2009 18:54:50 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 73F0534C6A for ; Sat, 18 Jul 2009 19:04:50 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20090716203709.cps5jkp0oo0wws8w-cebfxv@webmail.spamcop.net> <1247842149.25608.44.camel@mj> <20090718175558.GA8867@thorin> Content-Type: text/plain Date: Sat, 18 Jul 2009 18:54:49 -0400 Message-Id: <1247957689.3416.74.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] enable buildable targets by default X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jul 2009 22:55:00 -0000 On Sat, 2009-07-18 at 23:38 +0200, Vladimir 'phcoder' Serbinenko wrote: > > I fully agree. The idea with my proposal (we talked this on IRC, I think) > > was to simplify things, so I proposed that we enable everything so we don't > > have to provide flags, etc. > The main pro was to avoid frequent breakage as we experienced with grub-emu. I just use a script to build grub for all supported platforms with all supported options. It's quite good for finding such errors. As it stands now, there are no errors and no warnings. But it took a while to fix everything. I think we should eventually revert to not building debug tools by default. > > I prefer if we got rid of the flags, or at least most of them (lumping them > > together with a flag to disable debug tools or so), I agree. grub-emu, grub-fstest and efiemu are debug tools. Neither is needed for normal operation on any platform. > I'm undecided on this point. On one hand they can be useful if used > correctly on the other hand if removing them would avoid users doing > errors What kind of errors do you mean? > > and remove the summary > > message as well. > > > However I really think summary message should remain. It avoids > developpers to scroll through tons of messages to find out if the part > they need is built and if it isn't why The summary message is OK with me, be we should keep it short and to the point. -- Regards, Pavel Roskin