From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH 2/2] Disable lzo compression, lzma is doing its job just fine
Date: Sun, 19 Jul 2009 13:45:27 -0400 [thread overview]
Message-ID: <1248025527.2519.8.camel@mj> (raw)
In-Reply-To: <20090718181821.GC8867@thorin>
On Sat, 2009-07-18 at 20:18 +0200, Robert Millan wrote:
> It doesn't break things, since it's barely modified, and doesn't interact with
> the rest of the code, but simply having more code means an added work to
> maintain it when we restructure things, etc. It needs to pay off in some way.
Exactly.
Actually, my intention was to improve test coverage. To test lzma and
lzo, GRUB needs to be compiled twice.
If we want to support MacOS compilation properly (I mean local labels),
we'll need to adjust both lzma and lzo.
Extra code means more development time wasted on mostly unused code.
There then there is an issue of user choice. I think we are offering
too many choices without explaining what's behind it.
I could say lzo is "old and proven" and lzma is "new and more
effective", but since lzo is disabled by default and there are no
complaints about it, keeping lzo becomes pointless.
I don't think we are going to see compression much more effecting than
lzma to justify keeping the infrastructure for more than one compression
algorithm.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-07-19 17:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 23:40 [PATCH 1/2] Introduce grub_malloc0() Pavel Roskin
2009-07-15 23:40 ` [PATCH 2/2] Disable lzo compression, lzma is doing its job just fine Pavel Roskin
2009-07-16 16:24 ` Vladimir 'phcoder' Serbinenko
2009-07-18 18:18 ` Robert Millan
2009-07-19 17:45 ` Pavel Roskin [this message]
2009-07-19 18:24 ` Vladimir 'phcoder' Serbinenko
2009-07-19 20:33 ` Pavel Roskin
2009-07-16 15:22 ` [PATCH 1/2] Introduce grub_malloc0() Vladimir 'phcoder' Serbinenko
2009-07-16 15:41 ` Pavel Roskin
2009-07-16 15:53 ` Vladimir 'phcoder' Serbinenko
2009-07-17 15:02 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248025527.2519.8.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.