From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MScUe-0004ye-HR for mharc-grub-devel@gnu.org; Sun, 19 Jul 2009 15:56:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MScUc-0004vJ-IX for grub-devel@gnu.org; Sun, 19 Jul 2009 15:56:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MScUX-0004oL-3C for grub-devel@gnu.org; Sun, 19 Jul 2009 15:56:17 -0400 Received: from [199.232.76.173] (port=41551 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MScUW-0004o9-Oz for grub-devel@gnu.org; Sun, 19 Jul 2009 15:56:12 -0400 Received: from mx20.gnu.org ([199.232.41.8]:2488) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MScUW-0003dE-3R for grub-devel@gnu.org; Sun, 19 Jul 2009 15:56:12 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MScUU-00054l-VC for grub-devel@gnu.org; Sun, 19 Jul 2009 15:56:11 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 19 Jul 2009 15:56:09 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id B5AD334C6A for ; Sun, 19 Jul 2009 16:06:16 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20090719011129.nnkkuesb4cwwwoos-cebfxv@webmail.spamcop.net> Content-Type: text/plain Date: Sun, 19 Jul 2009 15:56:07 -0400 Message-Id: <1248033367.2519.11.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-Detected-Operating-System: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] AFS fixes and improvements X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2009 19:56:19 -0000 On Sun, 2009-07-19 at 17:34 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> It's better to split fixes from the new features. > Attached patches > >> > >> I don't have afs images around. It would be great if you test all new > >> functionality with valgrind. It's very good at finding mistakes in the > >> code. > >> > > I will do. I use the publically-available image from > > http://web.syllable.org/pages/get-Syllable.html#emulate I could not use those images directly, but I installed Syllable on a virtual hard drive under qemu. I could successfully read the image with the patches. I tried grub-fstest under valgrind, and it was fine. Thanks for the patches! -- Regards, Pavel Roskin