From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MSdIR-0003X0-4t for mharc-grub-devel@gnu.org; Sun, 19 Jul 2009 16:47:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MSdIP-0003Wi-3o for grub-devel@gnu.org; Sun, 19 Jul 2009 16:47:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MSdIK-0003WK-MK for grub-devel@gnu.org; Sun, 19 Jul 2009 16:47:44 -0400 Received: from [199.232.76.173] (port=59093 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSdIK-0003W9-HK for grub-devel@gnu.org; Sun, 19 Jul 2009 16:47:40 -0400 Received: from c60.cesmail.net ([216.154.195.49]:21392) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MSdIK-0007S7-0C for grub-devel@gnu.org; Sun, 19 Jul 2009 16:47:40 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 19 Jul 2009 16:47:38 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 1993F34C6A for ; Sun, 19 Jul 2009 16:57:45 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20090719011129.nnkkuesb4cwwwoos-cebfxv@webmail.spamcop.net> <1248033367.2519.11.camel@mj> <1248035572.2519.34.camel@mj> Content-Type: text/plain Date: Sun, 19 Jul 2009 16:47:36 -0400 Message-Id: <1248036456.2519.48.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] AFS fixes and improvements X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2009 20:47:45 -0000 On Sun, 2009-07-19 at 22:40 +0200, Vladimir 'phcoder' Serbinenko wrote: > > I prefer not to fix minor memory leaks by huge patches. I have a patch, > > I just wanted to look at the possibility to use grub_kzalloc() and > > allocating data as part of the partition. > Well nested partition patch changes the way how partitions are handled > and fix for memory leak probably wouldn't stay long and will just > cause an unnecessary rediffing. I prefer to commit a big patch and > then look if memory leak remains and if it's the case fix the memory > leak I think we should release 1.97 first. Sorry, I know that it's bad to sit on a pile of code, but in my opinion, the nested partition patch is too intrusive at this point. I was planning a detailed review of that patch, but I didn't have a chance. -- Regards, Pavel Roskin