All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] SOUND: OSS sequencer should be initialized after snd_seq_system_client_init
Date: Sun, 19 Jul 2009 23:19:47 +0100	[thread overview]
Message-ID: <1248041987.4302.6.camel@toshiba-laptop> (raw)
In-Reply-To: <1248020914.2471.4.camel@ht.satnam>

On Sun, 2009-07-19 at 21:58 +0530, Jaswinder Singh Rajput wrote:
> [PATCH] SOUND: OSS sequencer should be initialized after snd_seq_system_client_init
> 
> When build SND_SEQUENCER in kernel then OSS sequencer(alsa_seq_oss_init)
> is initialized before System (snd_seq_system_client_init) which leads to
> memory leak :

Thanks for investigating this. I haven't looked at the code in detail
but I find it a bit weird that initialisation order fixes the memory
leak. Shouldn't the memory allocation logic change slightly to avoid the
leak as well (that's in case someone manually inserts the modules in the
wrong order)?

-- 
Catalin


  parent reply	other threads:[~2009-07-19 22:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 20:14 kmemleak issues in alsa Jaswinder Singh Rajput
2009-07-19 12:07 ` Takashi Iwai
2009-07-19 15:26   ` Jaswinder Singh Rajput
2009-07-19 16:02     ` Takashi Iwai
2009-07-19 16:28       ` [PATCH] SOUND: OSS sequencer should be initialized after snd_seq_system_client_init Jaswinder Singh Rajput
2009-07-19 17:10         ` Takashi Iwai
2009-07-19 22:19         ` Catalin Marinas [this message]
2009-07-20  5:02           ` Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248041987.4302.6.camel@toshiba-laptop \
    --to=catalin.marinas@arm.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.