From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MTIur-0005IQ-O1 for mharc-grub-devel@gnu.org; Tue, 21 Jul 2009 13:14:13 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTIup-0005HD-Tm for grub-devel@gnu.org; Tue, 21 Jul 2009 13:14:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTIul-0005Fn-5w for grub-devel@gnu.org; Tue, 21 Jul 2009 13:14:11 -0400 Received: from [199.232.76.173] (port=50144 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTIuk-0005Fe-TF for grub-devel@gnu.org; Tue, 21 Jul 2009 13:14:06 -0400 Received: from c60.cesmail.net ([216.154.195.49]:35569) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MTIuk-0005cT-Eb for grub-devel@gnu.org; Tue, 21 Jul 2009 13:14:06 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 21 Jul 2009 13:14:04 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id C807E34C6A for ; Tue, 21 Jul 2009 13:24:28 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Tue, 21 Jul 2009 13:14:03 -0400 Message-Id: <1248196443.27068.86.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] UUID support for UFS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2009 17:14:12 -0000 On Tue, 2009-07-21 at 15:03 +0200, Vladimir 'phcoder' Serbinenko wrote: > + grub_sprintf (*uuid, "%08lx%08lx", > + (unsigned long) grub_le_to_cpu32 (data->sblock.uuidhi), > + (unsigned long) grub_le_to_cpu32 (data->sblock.uuidlow)); unsigned long is 64-bit on x86_64. unsigned int would do just fine here. Also, I don't see where this notation is used. The FreeBSD dumpfs prints two numbers in hex with a space between them. On Linux, udev doesn't create entries for UFS partitions under /dev/disk/by-uuid. Linux kernel doesn't print UUID at all. I would add a dash between the numbers to make it more readable unless there is a precedent where the dash is not used. Apart from that, the code looks good and the result matches the output of dumpfs. -- Regards, Pavel Roskin