From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MTLZo-0004G6-1t for mharc-grub-devel@gnu.org; Tue, 21 Jul 2009 16:04:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTLZm-0004FU-Fs for grub-devel@gnu.org; Tue, 21 Jul 2009 16:04:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTLZi-0004Da-0d for grub-devel@gnu.org; Tue, 21 Jul 2009 16:04:38 -0400 Received: from [199.232.76.173] (port=35298 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTLZh-0004DS-OR for grub-devel@gnu.org; Tue, 21 Jul 2009 16:04:33 -0400 Received: from c60.cesmail.net ([216.154.195.49]:64247) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MTLZg-0006AY-9O for grub-devel@gnu.org; Tue, 21 Jul 2009 16:04:32 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 21 Jul 2009 16:04:30 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 4954B34C6A for ; Tue, 21 Jul 2009 16:14:56 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <1248196443.27068.86.camel@mj> Content-Type: text/plain Date: Tue, 21 Jul 2009 16:04:29 -0400 Message-Id: <1248206669.3327.20.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] UUID support for UFS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2009 20:04:38 -0000 On Tue, 2009-07-21 at 22:01 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Jul 21, 2009 at 7:14 PM, Pavel Roskin wrote: > > On Tue, 2009-07-21 at 15:03 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> + grub_sprintf (*uuid, "%08lx%08lx", > >> + (unsigned long) grub_le_to_cpu32 (data->sblock.uuidhi), > >> + (unsigned long) grub_le_to_cpu32 (data->sblock.uuidlow)); > > > > unsigned long is 64-bit on x86_64. unsigned int would do just fine > > here. > Ok > > I would add a dash between the numbers to make it more readable unless > > there is a precedent where the dash is not used. > If you look into /dev/ufsid/ then you'll see that it has no dash. This > is also a syntax used in > set FreeBSD.vfs.root.mountfrom=ufs:ufsid/ > So making it with dash would need additional conversion to pass it to FreeBSD OK then. -- Regards, Pavel Roskin