From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MTMqF-0000eE-SI for mharc-grub-devel@gnu.org; Tue, 21 Jul 2009 17:25:43 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTMqD-0000dx-Vy for grub-devel@gnu.org; Tue, 21 Jul 2009 17:25:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTMq9-0000dA-7r for grub-devel@gnu.org; Tue, 21 Jul 2009 17:25:41 -0400 Received: from [199.232.76.173] (port=57385 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTMq9-0000d0-3T for grub-devel@gnu.org; Tue, 21 Jul 2009 17:25:37 -0400 Received: from c60.cesmail.net ([216.154.195.49]:5331) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MTMq8-0003rt-E3 for grub-devel@gnu.org; Tue, 21 Jul 2009 17:25:36 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 21 Jul 2009 17:25:33 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id CFE6F34C6A for ; Tue, 21 Jul 2009 17:35:58 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <1248192179.27068.18.camel@mj> Content-Type: text/plain Date: Tue, 21 Jul 2009 17:25:31 -0400 Message-Id: <1248211531.18091.5.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Support FreeBSD in osdetect.lua X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2009 21:25:42 -0000 On Tue, 2009-07-21 at 22:17 +0200, Vladimir 'phcoder' Serbinenko wrote: > Actually this menu is done to match the default one of FreeBSD loader. > I'm not a FreeBSD expert so I prefered to stick to the same menu as > default bootloader. I see. > > The implementation could remove the original menu, or it could insert > > entries immediately below "safe mode". I don't know if it's possible, > > but it could be useful. > > > Bean proposed something like this but I don't know his progress > > Actually, I don't want osdetect.lua to be overengineered and overloaded > > with intimate knowledge of different OSes. It's an example for others > > to extend, not a complete solution. > We put it into our repository this means that we accept improvements. > I also think that there will be distributions similar to Super GRUB > Disk and other recovery tools based on osdetect.lua. Unless we provide > a good reference osdetect.lua there will be a bitrot between such > distributions every one neglecting some OSes I don't fee strongly against your change. However, I would hate to see five lines for every Linux kernel (although it would be nice to have safe mode for Windows in the GRUB menu). So this should not be an example for other OSes. Obviously, the zfs part shouldn't go in yet. -- Regards, Pavel Roskin