From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MTNxz-0004wb-Il for mharc-grub-devel@gnu.org; Tue, 21 Jul 2009 18:37:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTNxx-0004wB-3z for grub-devel@gnu.org; Tue, 21 Jul 2009 18:37:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTNxr-0004vm-MZ for grub-devel@gnu.org; Tue, 21 Jul 2009 18:37:43 -0400 Received: from [199.232.76.173] (port=46442 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTNxr-0004vj-Hp for grub-devel@gnu.org; Tue, 21 Jul 2009 18:37:39 -0400 Received: from c60.cesmail.net ([216.154.195.49]:35938) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MTNxq-0005Im-N3 for grub-devel@gnu.org; Tue, 21 Jul 2009 18:37:39 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 21 Jul 2009 18:37:36 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 3288034C6A for ; Tue, 21 Jul 2009 18:48:03 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <4A66218A.3020506@gmail.com> References: <1248196443.27068.86.camel@mj> <4A660CE9.6040104@gmail.com> <1248211910.18091.8.camel@mj> <1248213902.18091.20.camel@mj> <4A66218A.3020506@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Date: Tue, 21 Jul 2009 18:37:35 -0400 Message-Id: <1248215855.18091.32.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] UUID support for UFS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2009 22:37:45 -0000 On Tue, 2009-07-21 at 22:14 +0200, Javier Martín wrote: > > But I would prefer that we work on fixing bugs rather than non-bugs. > > > "Fixing" this would allow us to have cleaner code, and separate "casual > variables" from fixed-length variables. If we print int with %d and > int32_t with PRId32, the impact of the subtle bugs that appear when we > port across architectures will be reduced. If int and int32_t are different types, gcc will warn about it, at least for implicit conversion with data loss. It's more likely that bugs will be introduced by that change, not fixed. Besides, the code will be harder to read. I'm not going to participate in this discussion anymore. I'm working on a real bug in the rmmod command that exists right now. It's more important than fixing potential bugs on architectures we don't support. -- Regards, Pavel Roskin