All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Lei <lei.alvin.gao@gmail.com>
To: "Luis R. Rodriguez" <mcgrof@winlab.rutgers.edu>
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH] compat-wireless-old: Fix problem with TX on amd64
Date: Thu, 23 Jul 2009 03:23:25 +0800	[thread overview]
Message-ID: <1248290605.4717.76.camel@mountain.triplerocks.net> (raw)

On amd64, the `ieee80211_tx_info' struct takes 56 bytes, thus cannot fit
into skb's control buffer.

The very first result is that nothing can be really sent out, because
skb's next member `len' also gets cleared when doing:

	info = IEEE80211_SKB_CB(skb);
	memset(info, 0, sizeof(*info));

A quick fix may be removing the TX control's sta pointer, since IMHO
it's rarely used for now (the only place that I found was a function
assigning values to it).

It has been working well for me so far, but please let me know if
there're better solutions. Thanks!

Best regards,
Gao Lei


diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index e3adf99..b9a5ae7 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -331,7 +331,6 @@ struct ieee80211_tx_info {
 		struct {
 			struct ieee80211_vif *vif;
 			struct ieee80211_key_conf *hw_key;
-			struct ieee80211_sta *sta;
 			unsigned long jiffies;
 			int ifindex;
 			u16 aid;
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 7d1b32c..ee0ed32 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -540,9 +540,6 @@ ieee80211_tx_h_misc(struct ieee80211_tx_data *tx)
 
 	sband = tx->local->hw.wiphy->bands[tx->channel->band];
 
-	if (tx->sta)
-		info->control.sta = &tx->sta->sta;
-
 	if (!info->control.retry_limit) {
 		if (!is_multicast_ether_addr(hdr->addr1)) {
 			int len = min_t(int, tx->skb->len + FCS_LEN,
@@ -620,9 +617,6 @@ ieee80211_tx_h_misc(struct ieee80211_tx_data *tx)
 			info->control.rts_cts_rate_idx = 0;
 	}
 
-	if (tx->sta)
-		info->control.sta = &tx->sta->sta;
-
 	return TX_CONTINUE;
 }
 


             reply	other threads:[~2009-07-22 19:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22 19:23 Gao Lei [this message]
2009-07-22 19:30 ` [PATCH] compat-wireless-old: Fix problem with TX on amd64 Luis R. Rodriguez
2009-07-23 18:54   ` Gao Lei
2009-07-23 19:03     ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248290605.4717.76.camel@mountain.triplerocks.net \
    --to=lei.alvin.gao@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@winlab.rutgers.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.